fix(validation): add nvidia-nim to shouldSkipResponsesProbe by ColinM-sys · Pull Request #2505 · NVIDIA/NemoClaw

ColinM-sys · 2026-04-27T07:26:19Z

`nvidia-prod` and `nvidia-nim` map to the same NVIDIA endpoint config
in `inference-config.ts` — same base URL, same credential env, same
`providerLabel: "NVIDIA Endpoints"`. Neither supports `/v1/responses`.

`nvidia-prod` was already listed in `shouldSkipResponsesProbe` but
`nvidia-nim` was missing, so sandboxes onboarded with the `nvidia-nim`
provider incorrectly ran the Responses probe against an endpoint that
does not expose it.

Signed-off-by: ColinM-sys cmcdonough@50words.com

Summary by CodeRabbit

New Features
- The nvidia-nim inference provider is now properly supported in the setup wizard's response validation logic, with consistent handling across all supported providers.
Tests
- Added unit test coverage to verify nvidia-nim provider response validation behavior.

nvidia-prod and nvidia-nim both map to the same NVIDIA endpoint config in inference-config.ts (same URL, same credential, same providerLabel). Neither supports /v1/responses. nvidia-prod was already listed but nvidia-nim was missing, so sandboxes onboarded with the nvidia-nim provider incorrectly ran the Responses probe against an endpoint that does not expose it. Signed-off-by: ColinM-sys <cmcdonough@50words.com>

copy-pr-bot · 2026-04-27T07:26:24Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

coderabbitai · 2026-04-27T07:26:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b35e4b60-896e-417a-a42a-a1db8e259221

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7f0c6 and 0bd5ad5.

📒 Files selected for processing (2)

src/lib/validation.test.ts
src/lib/validation.ts

📝 Walkthrough

Walkthrough

Extended the shouldSkipResponsesProbe function to treat the "nvidia-nim" provider the same as "nvidia-prod" and "gemini-api", skipping OpenAI Responses API probing. Added corresponding unit test to verify this behavior.

Changes

Cohort / File(s)	Summary
Responses Probe Skip Logic `src/lib/validation.ts`, `src/lib/validation.test.ts`	Extended `shouldSkipResponsesProbe` to skip responses probing for `"nvidia-nim"` provider alongside existing skip conditions. Added unit test verifying `nvidia-nim` is treated identically to `nvidia-prod`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A provider joins the skip list with grace,
nvidia-nim finds its proper place,
Responses probe need not probe at all,
Tests confirm this for one and all! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding nvidia-nim to the shouldSkipResponsesProbe function, which matches the actual code modifications in both validation.ts and validation.test.ts.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

wscurran · 2026-04-27T15:01:08Z

✨ Thanks for submitting this pull request that proposes a way to fix a bug where the nvidia-nim provider was missing from the shouldSkipResponsesProbe list. This identifies a bug and proposes a change to add nvidia-nim to the list, ensuring consistent handling across all supported providers.

## Summary Refreshes the 0.0.29 documentation for user-facing changes merged in the past 24 hours. Version metadata stays on `0.0.29`. ## Changes - `docs/get-started/quickstart.md`, `docs/reference/commands.md`, and `docs/reference/troubleshooting.md`: Document dashboard port auto-allocation, `--control-ui-port`, and `nemoclaw list` dashboard URL output from [#2411](#2411). - `docs/inference/inference-options.md` and `docs/inference/switch-inference-providers.md`: Document local Ollama and local vLLM credential isolation from `OPENAI_API_KEY` from [#2580](#2580). - `docs/inference/inference-options.md`: Document Local NVIDIA NIM validation behavior from [#2505](#2505). - `docs/reference/commands.md`: Document the cloud-only NIM status display behavior from [#2622](#2622). - `docs/deployment/deploy-to-remote-gpu.md`: Clarify runtime propagation for `NEMOCLAW_PROXY_HOST` and `NEMOCLAW_PROXY_PORT` from [#2581](#2581). - `docs/workspace/backup-restore.md`: Document snapshot restore symlink handling for sandbox data paths from [#2488](#2488). - `docs/reference/commands.md`: Document `skill install --help` and OpenClaw plugin-shaped directory guidance from [#2585](#2585). ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [ ] `npm test` passes - [ ] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [x] Docs updated for user-facing behavior changes - [x] `make docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) ## AI Disclosure - [x] AI-assisted — tool: Codex --- Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>  ## Summary by CodeRabbit * **Documentation** * Added `--control-ui-port` flag for explicit dashboard port control * Implemented automatic port selection (18789–18799) when the default port is occupied * Clarified that local inference routes (Ollama, local vLLM) don't require `OPENAI_API_KEY` * Improved dashboard URL display in list and status commands * Enhanced symlink handling in workspace backup restoration * Updated multi-sandbox quickstart and troubleshooting guidance

) \`nvidia-prod\` and \`nvidia-nim\` map to the same NVIDIA endpoint config in \`inference-config.ts\` — same base URL, same credential env, same \`providerLabel: "NVIDIA Endpoints"\`. Neither supports \`/v1/responses\`. \`nvidia-prod\` was already listed in \`shouldSkipResponsesProbe\` but \`nvidia-nim\` was missing, so sandboxes onboarded with the \`nvidia-nim\` provider incorrectly ran the Responses probe against an endpoint that does not expose it. Signed-off-by: ColinM-sys <cmcdonough@50words.com>  ## Summary by CodeRabbit * **New Features** * The nvidia-nim inference provider is now properly supported in the setup wizard's response validation logic, with consistent handling across all supported providers. * **Tests** * Added unit test coverage to verify nvidia-nim provider response validation behavior.  Signed-off-by: ColinM-sys <cmcdonough@50words.com>

## Summary Refreshes the 0.0.29 documentation for user-facing changes merged in the past 24 hours. Version metadata stays on `0.0.29`. ## Changes - `docs/get-started/quickstart.md`, `docs/reference/commands.md`, and `docs/reference/troubleshooting.md`: Document dashboard port auto-allocation, `--control-ui-port`, and `nemoclaw list` dashboard URL output from [NVIDIA#2411](NVIDIA#2411). - `docs/inference/inference-options.md` and `docs/inference/switch-inference-providers.md`: Document local Ollama and local vLLM credential isolation from `OPENAI_API_KEY` from [NVIDIA#2580](NVIDIA#2580). - `docs/inference/inference-options.md`: Document Local NVIDIA NIM validation behavior from [NVIDIA#2505](NVIDIA#2505). - `docs/reference/commands.md`: Document the cloud-only NIM status display behavior from [NVIDIA#2622](NVIDIA#2622). - `docs/deployment/deploy-to-remote-gpu.md`: Clarify runtime propagation for `NEMOCLAW_PROXY_HOST` and `NEMOCLAW_PROXY_PORT` from [NVIDIA#2581](NVIDIA#2581). - `docs/workspace/backup-restore.md`: Document snapshot restore symlink handling for sandbox data paths from [NVIDIA#2488](NVIDIA#2488). - `docs/reference/commands.md`: Document `skill install --help` and OpenClaw plugin-shaped directory guidance from [NVIDIA#2585](NVIDIA#2585). ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [ ] `npm test` passes - [ ] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [x] Docs updated for user-facing behavior changes - [x] `make docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) ## AI Disclosure - [x] AI-assisted — tool: Codex --- Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>  ## Summary by CodeRabbit * **Documentation** * Added `--control-ui-port` flag for explicit dashboard port control * Implemented automatic port selection (18789–18799) when the default port is occupied * Clarified that local inference routes (Ollama, local vLLM) don't require `OPENAI_API_KEY` * Improved dashboard URL display in list and status commands * Enhanced symlink handling in workspace backup restoration * Updated multi-sandbox quickstart and troubleshooting guidance

wscurran added bug Something fails against expected or documented behavior dependencies Pull requests that update a dependency file provider: nvidia NVIDIA inference endpoint, NIM, or NVIDIA provider behavior labels Apr 27, 2026

brandonpelfrey approved these changes Apr 28, 2026

View reviewed changes

brandonpelfrey merged commit aab7988 into NVIDIA:main Apr 28, 2026
2 checks passed

miyoungc mentioned this pull request Apr 29, 2026

docs: refresh daily docs for 0.0.29 #2650

Merged

13 tasks

wscurran added bug-fix PR fixes a bug or regression chore Build, CI, dependency, or tooling maintenance and removed bug Something fails against expected or documented behavior chore Build, CI, dependency, or tooling maintenance labels Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(validation): add nvidia-nim to shouldSkipResponsesProbe#2505

fix(validation): add nvidia-nim to shouldSkipResponsesProbe#2505
brandonpelfrey merged 1 commit into
NVIDIA:mainfrom
ColinM-sys:fix/validation-skip-responses-probe-nvidia-nim

ColinM-sys commented Apr 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

copy-pr-bot Bot commented Apr 27, 2026

Uh oh!

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

wscurran commented Apr 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ColinM-sys commented Apr 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

copy-pr-bot Bot commented Apr 27, 2026

Uh oh!

coderabbitai Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

wscurran commented Apr 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ColinM-sys commented Apr 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading