chore(test): apply shfmt formatting to E2E scripts#2359
Merged
Conversation
The squash merge of #2351 skipped pre-commit hooks, leaving shfmt formatting violations in the snapshot-commands and deployment-services test scripts. Run shfmt -w to fix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe PR updates the nemoclaw user reference documentation to include three new command sections: the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Keep main's CLOUDFLARED_DOWNLOAD_URL env var override while applying the branch's shfmt-style line continuation formatting (&&-at-EOL instead of backslash continuation).
The merge resolution used &&-at-EOL style but shfmt prefers backslash continuation with &&/|| at the start of the next line. Also fixes case-statement indentation in test-deployment-services.sh.
ksapru
pushed a commit
to ksapru/NemoClaw
that referenced
this pull request
May 12, 2026
## Summary The squash merge of NVIDIA#2351 skipped pre-commit hooks, leaving shfmt formatting violations that broke the `main` workflow checks. This applies `shfmt -w` to fix them. ## Test plan - [x] `shfmt -d` produces no diff on both files <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added documentation for `nemoclaw onboard --from <Dockerfile>` option for building sandbox images from custom Dockerfiles. * Added documentation for deprecated CLI aliases `nemoclaw start`/`nemoclaw stop` (use `nemoclaw tunnel start`/`nemoclaw tunnel stop` instead). * Added documentation for deprecated `nemoclaw setup` command (use `nemoclaw onboard` instead). <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The squash merge of #2351 skipped pre-commit hooks, leaving shfmt formatting violations that broke the
mainworkflow checks. This appliesshfmt -wto fix them.Test plan
shfmt -dproduces no diff on both filesSummary by CodeRabbit
nemoclaw onboard --from <Dockerfile>option for building sandbox images from custom Dockerfiles.nemoclaw start/nemoclaw stop(usenemoclaw tunnel start/nemoclaw tunnel stopinstead).nemoclaw setupcommand (usenemoclaw onboardinstead).