fix(test): tolerate version token in snapshot create success grep#2314
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe test script's snapshot creation success detection was relaxed: the success check now uses a regex that allows a version token between "Snapshot" and "created" (e.g., Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cv
approved these changes
Apr 23, 2026
Contributor
|
✨ Related open PRs: Related open issues: |
jyaunches
approved these changes
Apr 23, 2026
jyaunches
added a commit
that referenced
this pull request
Apr 23, 2026
Merge main into fix/nightly-e2e-repairs-v4, resolving conflicts: - nightly-e2e.yaml: keep contains(needs.*.result, 'failure') from #2371, remove cloud-experimental-e2e from notify-on-failure needs array - test-snapshot-commands.sh: keep exit-code check from this PR + tolerant grep regex from #2314 Address reviewer feedback: - Drop NEMOCLAW_RECREATE_SANDBOX from deployment-services to avoid re-introducing the delete+create race fixed in #2313 (@prekshivyas) - Update cloud-experimental-e2e disable comment: drop stale Landlock mention (fixed in OpenShell#810 v0.0.32+), reference only docs-drift (@prekshivyas) - Extract dump_diagnostics() in test-snapshot-commands.sh to centralize duplicate probes from fail() and Phase 2b (CodeRabbit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `test-snapshot-commands.sh` nightly E2E was failing despite `nemoclaw snapshot create` actually succeeding. The test greps for the literal string `"Snapshot created"` but the real success output includes a version token between:
```
✓ Snapshot v1 created (12 directories)
```
Grep didn't match → false red in nightly despite the command succeeding.
Switching to regex `"Snapshot v[0-9]+.*created"` that tolerates the version token.
Why found now
Investigating #2268 revealed this test reporting FAIL on a run where the operation had actually succeeded per the log. Pre-existing on main — predates both #2308 and any recent PR.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit