src/nemoclaw.ts (1)

1850-1882: Avoid rebuilds for no-op channel state changes

This flow rebuilds even when the channel is already in the requested state (e.g., stopping an already stopped channel). That adds unnecessary churn and wait time.

♻️ Suggested refinement

 async function sandboxChannelsSetEnabled(sandboxName, args, disabled) {
   const verb = disabled ? "stop" : "start";
   const dryRun = args.includes("--dry-run");
   const channelArg = args.find((arg) => !arg.startsWith("-"));
@@
   const normalized = channelArg.trim().toLowerCase();
+  const currentDisabled = new Set(registry.getDisabledChannels(sandboxName) || []).has(normalized);
+  if (currentDisabled === disabled) {
+    console.log(
+      `  Channel '${normalized}' is already ${disabled ? "disabled" : "enabled"} for '${sandboxName}'.`,
+    );
+    return;
+  }
+
   if (dryRun) {
     console.log(
       `  --dry-run: would ${verb} channel '${normalized}' for '${sandboxName}'.`,
     );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/nemoclaw.ts` around lines 1850 - 1882, The command always triggers
promptAndRebuild even when the channel is already in the requested state; update
sandboxChannelsSetEnabled to skip the rebuild for no-op changes: before calling
promptAndRebuild, check the current disabled/enabled state for the channel
(e.g., via registry.getSandbox(...) or registry.getChannel(...) or similar) and
if currentState === disabled then log a message like "channel already
{disabled|enabled} for '{sandboxName}'" and return; if such a read method
doesn't exist, change registry.setChannelDisabled to return a tri-state (e.g.,
false = sandbox not found, "no-change" = already in requested state, true =
state changed) or add a separate registry method that returns whether the call
actually changed state, then only call promptAndRebuild when a real state change
occurred.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/nemoclaw.ts (1)

1851-1900: Validate and reject extra args for channels start|stop.

channels start|stop currently consumes only the first positional channel and ignores other unexpected args/flags. Consider strict validation to avoid silent operator mistakes in scripts.

Proposed diff

 async function sandboxChannelsSetEnabled(sandboxName, args, disabled) {
   const verb = disabled ? "stop" : "start";
   const dryRun = args.includes("--dry-run");
-  const channelArg = args.find((arg) => !arg.startsWith("-"));
+  const channelArgs = args.filter((arg) => !arg.startsWith("-"));
+  const unknownFlags = args.filter((arg) => arg.startsWith("-") && arg !== "--dry-run");
+  if (unknownFlags.length > 0) {
+    console.error(`  Unknown argument(s): ${unknownFlags.join(", ")}`);
+    console.error(`  Usage: nemoclaw <sandbox> channels ${verb} <channel> [--dry-run]`);
+    process.exit(1);
+  }
+  const channelArg = channelArgs[0];
+  if (channelArgs.length > 1) {
+    console.error(`  Unexpected extra argument(s): ${channelArgs.slice(1).join(", ")}`);
+    console.error(`  Usage: nemoclaw <sandbox> channels ${verb} <channel> [--dry-run]`);
+    process.exit(1);
+  }
   if (!channelArg) {
     console.error(`  Usage: nemoclaw <sandbox> channels ${verb} <channel> [--dry-run]`);
     console.error(`  Valid channels: ${knownChannelNames().join(", ")}`);
     process.exit(1);
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/nemoclaw.ts` around lines 1851 - 1900, The sandboxChannelsSetEnabled
handler currently picks the first positional arg and ignores any extra
args/flags which can hide mistakes; update sandboxChannelsSetEnabled to strictly
validate args: accept exactly one positional channel name and optionally a
single flag --dry-run, reject any other flags or additional positional values,
printing the same usage/valid channels messages and exiting non-zero; reference
the existing symbols sandboxChannelsSetEnabled (entry point),
sandboxChannelsStart/sandboxChannelsStop (callers), knownChannelNames() (for
usage output), and registry.setChannelDisabled/promptAndRebuild (unchanged
success path) so you only add validation before getChannelDef and dry-run logic.