src/lib/inventory-commands.ts (1)

105-107: Remove the no-op live inference probe from inventory generation.

Line 105 to Line 107 calls getLiveInference() but discards the result, which adds external-call overhead without affecting output.

♻️ Proposed cleanup

-  if (recovery.sandboxes.length > 0) {
-    deps.getLiveInference();
-  }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/inventory-commands.ts` around lines 105 - 107, The call to
deps.getLiveInference() inside the recovery.sandboxes check is a no-op (its
return is discarded) and should be removed to avoid unnecessary external calls;
locate the block referencing recovery.sandboxes and deps.getLiveInference() in
inventory-commands.ts and delete that call (or, if the intent was to use its
result, replace the discarded call with proper handling/assignment or awaiting
of getLiveInference() where its value/side-effects are actually needed).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/nemoclaw.ts (1)

1183-1195: ⚠️ Potential issue | 🟡 Minor

Report only truly unknown list flags.

At Line 1193, using args.join(", ") can mislabel valid flags (e.g., --json --bogus) as unknown. This was already flagged in a previous review and is still present.

Suggested fix

 function parseListArgs(args = []) {
   const options = { json: false };
+  const unknownArgs = [];

   for (const arg of args) {
     if (arg === "--json") {
       options.json = true;
       continue;
@@
       console.log("");
       process.exit(0);
     }
-    console.error(`  Unknown argument(s) for list: ${args.join(", ")}`);
-    console.error("  Usage: nemoclaw list [--json]");
-    process.exit(1);
+    unknownArgs.push(arg);
+  }
+
+  if (unknownArgs.length > 0) {
+    console.error(`  Unknown argument(s) for list: ${unknownArgs.join(", ")}`);
+    console.error("  Usage: nemoclaw list [--json]");
+    process.exit(1);
   }

   return options;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/nemoclaw.ts` around lines 1183 - 1195, The current loop over for (const
arg of args) misreports unknown flags by logging args.join(", ") so valid flags
get labeled unknown; update the handler inside the loop to log only the
offending arg (use the loop variable arg) when it is neither "--json" nor help,
e.g., replace the console.error that uses args.join with one that interpolates
the single arg, then print usage and call process.exit(1) as before; keep
references to the same loop, options.json assignment, and process.exit call so
only the actual unknown flag is reported.

src/lib/list-command-deps.ts (1)

32-37: Cache failed SSH probes as null to avoid repeated timeout hits.

At Line 33, if sessionDeps.getSshProcesses() throws, cachedSshOutput stays undefined, so each sandbox row can retry the expensive probe and hit the timeout again.

Proposed fix

   let cachedSshOutput: string | null | undefined;
   const getCachedSshOutput = () => {
     if (cachedSshOutput === undefined && sessionDeps) {
-      cachedSshOutput = sessionDeps.getSshProcesses();
+      try {
+        cachedSshOutput = sessionDeps.getSshProcesses();
+      } catch {
+        cachedSshOutput = null;
+      }
     }
     return cachedSshOutput ?? null;
   };

Also applies to: 47-54

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/list-command-deps.ts` around lines 32 - 37, The current
getCachedSshOutput getter calls sessionDeps.getSshProcesses() without handling
exceptions so a thrown error leaves cachedSshOutput undefined and causes
repeated expensive retries; wrap the call in a try/catch, on success set
cachedSshOutput to the result and return it, and on any error set
cachedSshOutput = null and return null (so failures are cached), and apply the
same defensive try/catch + null-caching change to the other similar SSH probe
getter (the other occurrence that also references cachedSshOutput and
sessionDeps.getSshProcesses).