src/lib/agent-defs.ts (1)

157-157: Normalize custom dashboard labels before returning.

On Line [157], you validate d.label.trim() but return d.label as-is. Leading/trailing spaces can leak into output.

♻️ Proposed small normalization tweak

     get dashboard(): AgentDashboard {
       const d = (raw.dashboard as Partial<AgentDashboard>) || {};
       const kind: AgentDashboardKind = d.kind === "api" ? "api" : "ui";
       const defaultLabel = kind === "api" ? "API" : "UI";
+      const normalizedLabel = typeof d.label === "string" ? d.label.trim() : "";
       const rawPath = typeof d.path === "string" ? d.path.trim() : "";
       const path = rawPath ? (rawPath.startsWith("/") ? rawPath : `/${rawPath}`) : "/";
       return {
         kind,
-        label: typeof d.label === "string" && d.label.trim() ? d.label : defaultLabel,
+        label: normalizedLabel || defaultLabel,
         path,
       };
     },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/agent-defs.ts` at line 157, The label return currently validates
d.label with d.label.trim() but returns the original string, allowing
leading/trailing whitespace to persist; update the logic that builds the label
(the property using d.label) to return the trimmed string (e.g., use
d.label.trim()) when d.label is a non-empty string, otherwise fall back to
defaultLabel—optionally compute a normalizedLabel variable before returning to
avoid double-trimming and improve readability.

src/lib/agent-onboard.test.ts (1)

34-44: Restore console.log spy to avoid global test-state leakage.

On line 34, console.log is mocked once and never restored. The Vitest configuration does not have restoreMocks enabled, so the spy will persist across tests. Add a restore hook to ensure this file doesn't leak mock state to other tests.

Suggested fix

-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+import { describe, it, expect, beforeEach, afterEach, afterAll, vi } from "vitest";
@@
   afterEach(() => {
     logSpy.mockClear();
   });
+
+  afterAll(() => {
+    logSpy.mockRestore();
+  });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/agent-onboard.test.ts` around lines 34 - 44, The console.log spy
(logSpy) is mocked but never restored which can leak mock state; add a restore
hook (e.g., call logSpy.mockRestore() in an afterAll or at the end of afterEach)
so the spy is removed after tests complete; update the test file to call
logSpy.mockRestore() (referencing the existing logSpy variable) in a teardown
hook (afterAll or afterEach) instead of only clearing mocks.