refactor(ts-migration): move onboard and cli to typescript by cv · Pull Request #1673 · NVIDIA/NemoClaw

cv · 2026-04-09T05:08:56Z

Summary

add the final mechanical migration phase manifest
mechanically move bin/lib/onboard.js to src/lib/onboard.ts
mechanically move bin/nemoclaw.js to src/nemoclaw.ts
leave compatibility wrappers in bin/
rename the remaining root CLI tests from .js to .ts
retarget source-inspection assertions to the new TS source where appropriate

Testing

npm run build:cli
npm run typecheck:cli
npm run lint
npx vitest run test/cli.test.ts test/install-preflight.test.ts test/onboard-readiness.test.ts test/onboard-selection.test.ts test/onboard.test.ts test/runner.test.ts test/credential-exposure.test.ts test/gateway-cleanup.test.ts test/shellquote-sandbox.test.ts
npm test

Summary by CodeRabbit

New Features
- Implemented CLI command dispatcher with support for sandbox management (connect, status, destroy).
- Added gateway health checks and automatic recovery mechanisms.
- Enhanced sandbox validation and reconciliation against live gateway state.
- Added credentials and policy management commands.
Chores
- Migrated CLI implementation to TypeScript.

coderabbitai · 2026-04-09T05:09:03Z

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request migrates CLI implementation from JavaScript to TypeScript. The entry point bin/nemoclaw.js is simplified to delegate to a compiled module, while a new src/nemoclaw.ts provides the full CLI dispatcher with command routing, sandbox lifecycle management, gateway health checks, and recovery logic. Multiple test files are updated to reference TypeScript source locations instead of compiled JavaScript artifacts.

Changes

Cohort / File(s)	Summary
CLI Entry Point `bin/nemoclaw.js`, `src/nemoclaw.ts`	Refactored from 1444-line inline implementation to a delegating shim. New TypeScript entrypoint consolidates command dispatch, OpenShell binary resolution, sandbox validation/reconciliation, gateway health checks with SSH-based probing, recovery mechanisms (lock cleanup, gateway restart, port forward re-establishment), policy management, credentials handling, and colored terminal output with `NO_COLOR` support.
Migration Configuration `scripts/ts-migration/phases/09-onboard-cli.json`	New phase configuration file directing test file renames, relocation of `bin/lib/onboard.js` → `src/lib/onboard.ts` and `bin/nemoclaw.js` → `src/nemoclaw.ts`, and shim strategy assignment (`simple` for onboard, `cli-launcher` for nemoclaw).
Test Updates `test/cli.test.ts`, `test/credential-exposure.test.ts`, `test/gateway-cleanup.test.ts`, `test/install-preflight.test.ts`, `test/onboard-readiness.test.ts`, `test/onboard-selection.test.ts`, `test/onboard.test.ts`, `test/runner.test.ts`, `test/shellquote-sandbox.test.ts`	Updated source file references from `bin/lib/onboard.js` and `bin/nemoclaw.js` to `src/lib/onboard.ts` and `src/nemoclaw.ts`. Added `//` @ts-nocheck`` directives to disable TypeScript checks. Updated assertion messages and path strings to reflect new locations.

Sequence Diagram

sequenceDiagram
    participant CLI as CLI Dispatcher
    participant OpenShell as OpenShell Binary
    participant Gateway as Gateway (SSH)
    participant Registry as Sandbox Registry
    participant Reconcile as Reconciliation

    CLI->>OpenShell: Resolve & invoke binary
    OpenShell-->>CLI: Running
    CLI->>Registry: Validate sandbox names
    Registry-->>CLI: Sandbox list
    CLI->>Gateway: Check each sandbox status via SSH
    
    alt Gateway Responsive
        Gateway-->>CLI: Sandbox present/missing
        CLI->>Reconcile: Classify state (present/missing/error)
    else Gateway Unresponsive
        Gateway-->>CLI: Connection error
        CLI->>CLI: Re-establish nemoclaw gateway
        CLI->>Gateway: Retry sandbox reconciliation
    end
    
    alt Recovery Needed
        CLI->>Gateway: Run recovery script (cleanup locks)
        Gateway->>Gateway: Clean temp files, restart
        CLI->>Gateway: Re-establish port forward
    end
    
    Reconcile-->>CLI: Reconciliation outcome
    CLI-->>CLI: Execute command (connect/status/deploy)

Estimated Code Review Effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Poem

🐰 Hop, skip, and a TypeScript bound!
Our CLI found a TypeScript ground,
Sandbox and gateway dance in sync,
No more compiled artifacts on the brink,
Tests now follow the new .ts link! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.41% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(ts-migration): move onboard and cli to typescript' clearly summarizes the main change: migrating onboard and CLI components from JavaScript to TypeScript as part of a larger ts-migration effort.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ts-migration/09-onboard-cli

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…rd-cli Signed-off-by: Aaron Erickson <aerickson@nvidia.com> # Conflicts: # scripts/migrate-js-to-ts.ts # test/skills-frontmatter.test.ts

- add the final mechanical migration phase manifest - mechanically move `bin/lib/onboard.js` to `src/lib/onboard.ts` - mechanically move `bin/nemoclaw.js` to `src/nemoclaw.ts` - leave compatibility wrappers in `bin/` - rename the remaining root CLI tests from `.js` to `.ts` - retarget source-inspection assertions to the new TS source where appropriate - npm run build:cli - npm run typecheck:cli - npm run lint - npx vitest run test/cli.test.ts test/install-preflight.test.ts test/onboard-readiness.test.ts test/onboard-selection.test.ts test/onboard.test.ts test/runner.test.ts test/credential-exposure.test.ts test/gateway-cleanup.test.ts test/shellquote-sandbox.test.ts - npm test  * **New Features** * Implemented CLI command dispatcher with support for sandbox management (connect, status, destroy). * Added gateway health checks and automatic recovery mechanisms. * Enhanced sandbox validation and reconciliation against live gateway state. * Added credentials and policy management commands. * **Chores** * Migrated CLI implementation to TypeScript.  --------- Co-authored-by: Aaron Erickson <aerickson@nvidia.com>

Main underwent a large-scale refactoring while this PR was open: - JS→TS migration: bin/lib/onboard.js → src/lib/onboard.ts, bin/nemoclaw.js → src/nemoclaw.ts (NVIDIA#1673) - Legacy shim removal: 18 bin/lib/*.js files deleted (NVIDIA#1713) - Command handler extraction: src/lib/onboard-command.ts (NVIDIA#1710) - Test renames: .js → .ts across all test files Conflict resolution: - bin/nemoclaw.js: accept main's 6-line launcher (logic in src/nemoclaw.ts) - src/lib/onboard.ts: take main's build context staging (fromDockerfile + agent + stageOptimized), keep Jetson gateway patch functions - docs/get-started/quickstart.md: use main's table format, add Jetson row - test/onboard.test.js: accept deletion (migrated to .ts) Re-ported Jetson features onto new TS structure: - Add setup-jetson to GLOBAL_COMMANDS, help text, and switch dispatch in src/nemoclaw.ts (not a deprecated alias — runs setup-jetson.sh) - Add Jetson to ci/platform-matrix.json (source of truth for docs table) - Add getGatewayImageTag and patchGatewayImageForJetson to exports in src/lib/onboard.ts - Port 4 Jetson tests to test/onboard.test.ts (dist/lib/onboard paths) Verified on Jetson Orin Nano Super (8GB, JetPack 6.x, Node 22.22.0): - Build: tsc passes - 4 Jetson tests: all pass - GPU: jetson=true, 7619 MB unified memory - Gateway: iptables v1.8.10 (legacy), io.nemoclaw.jetson-patched=true - Sandbox: Phase Ready - Inference: openclaw agent → "2 + 2 = 4." - Path: sandbox → host.openshell.internal:11434 → Ollama → nemotron-3-nano:4b Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

## Summary - add the final mechanical migration phase manifest - mechanically move `bin/lib/onboard.js` to `src/lib/onboard.ts` - mechanically move `bin/nemoclaw.js` to `src/nemoclaw.ts` - leave compatibility wrappers in `bin/` - rename the remaining root CLI tests from `.js` to `.ts` - retarget source-inspection assertions to the new TS source where appropriate ## Testing - npm run build:cli - npm run typecheck:cli - npm run lint - npx vitest run test/cli.test.ts test/install-preflight.test.ts test/onboard-readiness.test.ts test/onboard-selection.test.ts test/onboard.test.ts test/runner.test.ts test/credential-exposure.test.ts test/gateway-cleanup.test.ts test/shellquote-sandbox.test.ts - npm test  ## Summary by CodeRabbit * **New Features** * Implemented CLI command dispatcher with support for sandbox management (connect, status, destroy). * Added gateway health checks and automatic recovery mechanisms. * Enhanced sandbox validation and reconciliation against live gateway state. * Added credentials and policy management commands. * **Chores** * Migrated CLI implementation to TypeScript.  --------- Co-authored-by: Aaron Erickson <aerickson@nvidia.com>

@chandler-barlow

…detection (#1978) ## Summary Supersedes #1716. Using `localhost` can resolve to IPv6 (`::1`) on some systems, causing local inference health checks, probe commands, and model queries to fail silently. This replaces all host-side `localhost` references with explicit `127.0.0.1` for deterministic IPv4 behavior. Based on the original work in #1716 by @chandler-barlow — the JS→TS migration (#1673) made the original PR unrebaseable, so the change has been re-applied on the current codebase with attribution. ## Changes - `src/lib/local-inference.ts`: validation URLs, health endpoints, error messages, model queries, warmup/probe commands - `src/lib/nim.ts`: NIM health check curls - `src/lib/onboard.ts`: Ollama and vLLM detection curls - `src/lib/local-inference.test.ts`: updated expectations - `src/lib/nim.test.ts`: updated mock matchers - `test/cli.test.ts`: updated status output assertion - `test/onboard-selection.test.ts`: updated mock matchers - `test/e2e/test-gpu-e2e.sh`: host-side Ollama curls ## Test plan - [x] 50 unit tests passing (local-inference + nim) - [x] Zero `http://localhost:11434` or `http://localhost:8000` references remain in src/ test/ scripts/ - [x] Dashboard URLs intentionally unchanged (different scope) Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>  ## Summary by CodeRabbit * **Bug Fixes** * Improved reliability of local inference and onboarding checks by standardizing local service addresses to the loopback IP. * **Tests** * Updated unit, integration, and end-to-end test expectations and scripts to match the adjusted loopback addressing and health-check behavior.  --------- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> Co-authored-by: Chandler Barlow <cbarlow@nvidia.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cv added 11 commits April 8, 2026 21:07

chore(ts-migration): add mechanical migration tooling

a32c5d1

test(ts-migration): rename low-risk tests batch a

a4c74ac

test(ts-migration): rename low-risk tests batch b

2f2c8b3

test(ts-migration): rename medium tests batch c

7813eb5

test(ts-migration): rename root tests batch d

4249616

refactor(ts-migration): move runtime leaves to typescript

d655271

refactor(ts-migration): move runtime leaves to typescript

ec0fd3b

refactor(ts-migration): move runner to typescript

abfb21c

refactor(ts-migration): move policies to typescript

5449f56

test(ts-migration): rename remaining misc tests

fd6f7af

refactor(ts-migration): move onboard and cli to typescript

4db804a

test(ts-migration): point skills hook at ts test

8a812b6

cv mentioned this pull request Apr 9, 2026

Track review and merge of the mechanical JS→TS migration stack #1680

Closed

wscurran added CI/CD refactor PR restructures code without intended behavior change labels Apr 9, 2026

cv added the v0.0.11 label Apr 9, 2026

ericksoa changed the base branch from ts-migration/08-tests-e to main April 9, 2026 18:04

Merge remote-tracking branch 'origin/main' into ts-migration/09-onboa…

981447f

…rd-cli Signed-off-by: Aaron Erickson <aerickson@nvidia.com> # Conflicts: # scripts/migrate-js-to-ts.ts # test/skills-frontmatter.test.ts

ericksoa approved these changes Apr 9, 2026

View reviewed changes

ericksoa merged commit 1e59846 into main Apr 9, 2026
8 of 9 checks passed

kagura-agent mentioned this pull request Apr 9, 2026

fix(onboard): filter policy presets by enabled channels, not stored credentials #1651

Closed

kagura-agent mentioned this pull request Apr 10, 2026

fix(onboard): persist enabledChannels across resume path #1703

Merged

ericksoa mentioned this pull request Apr 11, 2026

fix(security): disable remote uninstall execution fallback #1476

Merged

16 tasks

realkim93 mentioned this pull request Apr 12, 2026

feat: add Jetson Orin Nano support #405

Open

9 tasks

HagegeR mentioned this pull request Apr 12, 2026

feat(scripts): add upgrade-sandbox.sh and non-interactive inference hydration #902

Closed

10 tasks

wscurran mentioned this pull request Apr 14, 2026

fix: use current Brev create flags (Fixes #998) #1038

Closed

jyaunches mentioned this pull request Apr 14, 2026

fix(security): use argv arrays for docker and curl to prevent shell injection #171

Closed

3 tasks

prekshivyas mentioned this pull request Apr 16, 2026

fix(onboard): use 127.0.0.1 instead of localhost for local inference detection #1978

Merged

3 tasks

cv deleted the ts-migration/09-onboard-cli branch May 27, 2026 21:19

wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions chore Build, CI, dependency, or tooling maintenance and removed CI/CD chore Build, CI, dependency, or tooling maintenance labels Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ts-migration): move onboard and cli to typescript#1673

refactor(ts-migration): move onboard and cli to typescript#1673
ericksoa merged 13 commits into
mainfrom
ts-migration/09-onboard-cli

cv commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram

Estimated Code Review Effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cv commented Apr 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram

Estimated Code Review Effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cv commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading