fix(test): update onboard test mocks to match shell-quoted sandboxName#1566
Merged
Conversation
The shell-quoting security fix (8f8b4e7) wrapped sandboxName with shellQuote() in exec and DNS proxy commands, but the test mocks still matched the unquoted format causing 4 CI failures (3 timeouts, 1 assertion error). Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated test logic: onboarding test matchers now detect Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
gemini2026
pushed a commit
to gemini2026/NemoClaw
that referenced
this pull request
Apr 14, 2026
NVIDIA#1566) ## Summary - Update 6 `runCapture` mock matchers in `test/onboard.test.js` to match the shell-quoted sandbox name format introduced by 8f8b4e7 - The security fix wrapped `sandboxName` with `shellQuote()` in exec and DNS proxy commands, but the test mocks still matched the old unquoted format (`sandbox exec my-assistant curl` vs `sandbox exec 'my-assistant' curl`) - This caused 4 CI failures: 3 timeouts (dashboard readiness loop never matched) and 1 assertion error (`null !== 0`) ## Test plan - [x] `npx vitest run` — all 1126 tests pass (67 files, 0 failures) - [x] All pre-commit and pre-push hooks pass Fixes the CI break introduced by NVIDIA#1392. Signed-off-by: Aaron Erickson <aerickson@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Updated test matchers to correctly detect sandbox invocations that use a quoted sandbox name in command strings. * Simplified test logic for scanning run/runCapture templates into an equivalent single-line expression, preserving existing violation detection and assertions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runCapturemock matchers intest/onboard.test.jsto match the shell-quoted sandbox name format introduced by 8f8b4e7sandboxNamewithshellQuote()in exec and DNS proxy commands, but the test mocks still matched the old unquoted format (sandbox exec my-assistant curlvssandbox exec 'my-assistant' curl)null !== 0)Test plan
npx vitest run— all 1126 tests pass (67 files, 0 failures)Fixes the CI break introduced by #1392.
Signed-off-by: Aaron Erickson aerickson@nvidia.com
Summary by CodeRabbit