fix: revert unauthorized CLAUDE.md change from #1081#1511
Merged
Conversation
The security credential injection PR (#1081) inadvertently included an unrelated CLAUDE.md modification that added a "Claude Behavior Rules" section. This was not part of the reviewed security change and was never requested. Revert CLAUDE.md to its pre-#1081 state. Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoval of the "Claude Behavior Rules" section from CLAUDE.md, which previously contained instructions for triggering nightly E2E test runs via a specific GitHub CLI dispatch command. No functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
tranzmatt
pushed a commit
to tranzmatt/NemoClaw
that referenced
this pull request
Apr 6, 2026
## Summary - Reverts the unrelated `CLAUDE.md` modification that was inadvertently included in the security credential injection PR (NVIDIA#1081) - The added "Claude Behavior Rules" section was never reviewed as part of that security change and was not requested ## Test plan - [x] Verify `CLAUDE.md` matches its pre-NVIDIA#1081 state - [x] No other files affected <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Removed obsolete internal documentation entries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
gemini2026
pushed a commit
to gemini2026/NemoClaw
that referenced
this pull request
Apr 14, 2026
## Summary - Reverts the unrelated `CLAUDE.md` modification that was inadvertently included in the security credential injection PR (NVIDIA#1081) - The added "Claude Behavior Rules" section was never reviewed as part of that security change and was not requested ## Test plan - [x] Verify `CLAUDE.md` matches its pre-NVIDIA#1081 state - [x] No other files affected <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Removed obsolete internal documentation entries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdmodification that was inadvertently included in the security credential injection PR (fix(security): use providers for messaging credential injection #1081)Test plan
CLAUDE.mdmatches its pre-fix(security): use providers for messaging credential injection #1081 stateSummary by CodeRabbit