refactor(installer): thin bootstrap and versioned payload#1395
Merged
Conversation
Contributor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe PR replaces the full end-to-end root installer with a lightweight bootstrap Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Bootstrap as install.sh<br/>(Bootstrap)
participant Git as Git Clone
participant Payload as scripts/install.sh<br/>(Versioned Installer)
participant NodeMgr as Node.js<br/>(nvm)
participant NemoClaw as NemoClaw<br/>Installer
participant Onboard as Onboarding
User->>Bootstrap: Run install.sh [--tag ref | --help/--version]
Bootstrap->>Git: Clone repo at NEMOCLAW_INSTALL_TAG (temp dir)
Git-->>Bootstrap: Repo cloned
alt payload marker present in clone
Bootstrap->>Payload: Execute `scripts/install.sh` with env (NEMOCLAW_INSTALL_REF/TAG/REPO_ROOT)
else fallback to root installer
Bootstrap->>Bootstrap: Execute legacy root `install.sh`
end
Payload->>NodeMgr: Fetch/install nvm and Node 22, validate runtime
NodeMgr-->>Payload: Node/npm ready
Payload->>NemoClaw: Install from local source or clone release, npm install, build, link CLI
NemoClaw-->>Payload: CLI installed, PATH/shims adjusted
Payload->>Payload: Verify `nemoclaw` in PATH
alt CLI resolvable
Payload->>Onboard: Run `nemoclaw onboard` (TTY-aware, may resume)
Onboard-->>Payload: Onboarding complete
else PATH unresolved
Payload->>User: Print shell PATH export/source hint
end
Payload-->>User: Installation complete
sequenceDiagram
participant TestRunner as Test Runner
participant StubGit as Stubbed Git/Repo
participant OldPayload as Old scripts/install.sh<br/>(Wrapper)
participant RootInstaller as Root install.sh<br/>(Legacy)
participant LogFile as LEGACY_LOG_PATH
TestRunner->>StubGit: Create stub repo containing old `scripts/install.sh` wrapper
StubGit-->>TestRunner: Stub ready
TestRunner->>OldPayload: Pipe installer via `bash -s -- --help`
OldPayload->>OldPayload: Detect absence of payload marker
OldPayload->>RootInstaller: Exec legacy root installer (fallback)
RootInstaller->>LogFile: Record `NEMOCLAW_INSTALL_TAG`
RootInstaller-->>TestRunner: Exit 0
TestRunner->>TestRunner: Assert tag logged and exit status success
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
scripts/install/installer.sh (2)
655-658: Consider adding SHA-256 verification for the Ollama installer.Unlike the nvm installer (which has SHA-256 verification), the Ollama installer is only checked for shebang presence. While
verify_downloaded_scripthelps detect download corruption, it doesn't protect against a compromised installer.This is a lower priority than nvm since Ollama installation is conditional on GPU presence and the official installer is from ollama.com. However, consider adding hash verification for defense in depth if a known-good hash can be maintained.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/install/installer.sh` around lines 655 - 658, The Ollama installer download is only validated for a shebang via verify_downloaded_script which doesn't protect against a compromised binary; modify the install sequence around the curl -> verify_downloaded_script -> sh "$tmpdir/install_ollama.sh" flow to perform a SHA-256 check: obtain a trusted expected hash (hardcoded in the script or fetched from a trusted URL), compute the downloaded file's SHA-256 (using sha256sum or shasum -a 256), compare it to the expected value, and abort with a clear error if it does not match before calling sh; update the code referencing "$tmpdir/install_ollama.sh" and the verify_downloaded_script invocation to include this new verification step.
336-340: Potential issue with local variable declaration in conditional branches.The
localdeclaration inside theif/elsebranches is unusual and may cause issues. In bash,localshould be declared at the start of the function scope, and then assigned conditionally.♻️ Suggested fix
+ local status if wait "$pid"; then - local status=0 + status=0 else - local status=$? + status=$? fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/install/installer.sh` around lines 336 - 340, The conditional declares "local" inside both branches which is unsafe; move the local declaration for the status variable to the top of the surrounding function (e.g., add "local status" before using wait "$pid"), then inside the if/else just assign status=0 or status=$? after wait "$pid"; update the block that uses wait "$pid" (the wait "$pid" lines) to only set status instead of declaring it locally in each branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/install/installer.sh`:
- Around line 655-658: The Ollama installer download is only validated for a
shebang via verify_downloaded_script which doesn't protect against a compromised
binary; modify the install sequence around the curl -> verify_downloaded_script
-> sh "$tmpdir/install_ollama.sh" flow to perform a SHA-256 check: obtain a
trusted expected hash (hardcoded in the script or fetched from a trusted URL),
compute the downloaded file's SHA-256 (using sha256sum or shasum -a 256),
compare it to the expected value, and abort with a clear error if it does not
match before calling sh; update the code referencing "$tmpdir/install_ollama.sh"
and the verify_downloaded_script invocation to include this new verification
step.
- Around line 336-340: The conditional declares "local" inside both branches
which is unsafe; move the local declaration for the status variable to the top
of the surrounding function (e.g., add "local status" before using wait "$pid"),
then inside the if/else just assign status=0 or status=$? after wait "$pid";
update the block that uses wait "$pid" (the wait "$pid" lines) to only set
status instead of declaring it locally in each branch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0cf5ecbb-1a2a-4dbd-9b91-af03c9f229d4
📒 Files selected for processing (3)
install.shscripts/install/installer.shtest/install-preflight.test.js
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/install.sh`:
- Around line 818-826: The installer branches off the caller's current working
directory and a whitespace-sensitive grep instead of using the selected checkout
in NEMOCLAW_REPO_ROOT; update the logic so it reads and checks
"$NEMOCLAW_REPO_ROOT/package.json" (use a whitespace-tolerant match, e.g.
'"name":[[:space:]]*"nemoclaw"') and set
NEMOCLAW_SOURCE_ROOT="$NEMOCLAW_REPO_ROOT" when that file matches, then run the
subsequent npm/spin commands from that directory (either cd
"$NEMOCLAW_SOURCE_ROOT" before the spin lines or wrap each bash -c spin command
to cd into NEMOCLAW_SOURCE_ROOT first) so npm install, npm run, and npm link
operate on the chosen repo, not the caller's pwd; reference symbols:
NEMOCLAW_REPO_ROOT, NEMOCLAW_SOURCE_ROOT, and the spin "Installing NemoClaw
dependencies"/"Building NemoClaw CLI modules"/"Linking NemoClaw CLI" commands.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 18de4ab6-70b4-42a8-891a-540ff2d09d0e
📒 Files selected for processing (3)
install.shscripts/install.shtest/install-preflight.test.js
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
scripts/install.sh (1)
819-827:⚠️ Potential issue | 🔴 CriticalUse the selected checkout instead of
$PWDfor source installs.This branch still probes
./package.jsonand runs the npm steps from the caller’s working directory. If the installer is launched from inside another checkout—or any directory with a matchingpackage.json—it can build and link that tree instead of the ref it just selected. The exact-stringgrepis whitespace-sensitive too.🛠️ Proposed fix
- if [[ -f "./package.json" ]] && grep -q '"name": "nemoclaw"' ./package.json 2>/dev/null; then - info "NemoClaw package.json found in current directory — installing from source…" - NEMOCLAW_SOURCE_ROOT="$(pwd)" - spin "Preparing OpenClaw package" bash -c "$(declare -f info warn resolve_openclaw_version pre_extract_openclaw); pre_extract_openclaw \"\$1\"" _ "$(pwd)" \ + local repo_root package_json + repo_root="$(resolve_repo_root)" + package_json="${repo_root}/package.json" + if [[ -f "$package_json" ]] && node -e 'process.exit(require(process.argv[1]).name === "nemoclaw" ? 0 : 1)' "$package_json" 2>/dev/null; then + info "NemoClaw package.json found in the selected checkout — installing from source…" + NEMOCLAW_SOURCE_ROOT="$repo_root" + spin "Preparing OpenClaw package" bash -c "$(declare -f info warn resolve_openclaw_version pre_extract_openclaw); pre_extract_openclaw \"\$1\"" _ "$repo_root" \ || warn "Pre-extraction failed — npm install may fail if openclaw tarball is broken" - spin "Installing NemoClaw dependencies" npm install --ignore-scripts - spin "Building NemoClaw CLI modules" npm run --if-present build:cli - spin "Building NemoClaw plugin" bash -c 'cd nemoclaw && npm install --ignore-scripts && npm run build' - spin "Linking NemoClaw CLI" npm link + spin "Installing NemoClaw dependencies" bash -c 'cd "$1" && npm install --ignore-scripts' _ "$repo_root" + spin "Building NemoClaw CLI modules" bash -c 'cd "$1" && npm run --if-present build:cli' _ "$repo_root" + spin "Building NemoClaw plugin" bash -c 'cd "$1"/nemoclaw && npm install --ignore-scripts && npm run build' _ "$repo_root" + spin "Linking NemoClaw CLI" bash -c 'cd "$1" && npm link' _ "$repo_root"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/install.sh` around lines 819 - 827, The installer currently reads ./package.json and uses $(pwd), which can target the caller's CWD instead of the selected checkout; change the logic to detect and operate on the selected checkout path by setting NEMOCLAW_SOURCE_ROOT to the resolved/checked-out directory (not "$(pwd)"), run the grep against "$NEMOCLAW_SOURCE_ROOT/package.json" (use a more robust regex like '"name":\s*"nemoclaw"'), invoke pre_extract_openclaw via spin with the source root as the argument (spin ... pre_extract_openclaw "$1" _ "$NEMOCLAW_SOURCE_ROOT"), and ensure all subsequent npm steps (spin "Installing NemoClaw dependencies", "Building NemoClaw CLI modules", "Building NemoClaw plugin", "Linking NemoClaw CLI") are run with a cd into "$NEMOCLAW_SOURCE_ROOT" (or otherwise pass that directory) so npm install, npm run, and npm link operate on the selected checkout rather than the current working directory; reference NEMOCLAW_SOURCE_ROOT, pre_extract_openclaw, and the spin invocations when making the edits.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@install.sh`:
- Around line 109-119: The current logic sources LOCAL_PAYLOAD even when the
installer is read from stdin, causing local checkout payloads to be used; change
the sourcing guard around has_payload_marker/LOCAL_PAYLOAD so it only sources
when the script is being executed from a real file (i.e., BASH_SOURCE[0] refers
to an existing readable file and is not the stdin/built-in shell invocation),
and ensure the runtime dispatch that calls main vs bootstrap_main uses the same
“script is a real file” test; update the checks around has_payload_marker,
LOCAL_PAYLOAD, BASH_SOURCE, main, and bootstrap_main so stdin installs never
source the local payload.
---
Duplicate comments:
In `@scripts/install.sh`:
- Around line 819-827: The installer currently reads ./package.json and uses
$(pwd), which can target the caller's CWD instead of the selected checkout;
change the logic to detect and operate on the selected checkout path by setting
NEMOCLAW_SOURCE_ROOT to the resolved/checked-out directory (not "$(pwd)"), run
the grep against "$NEMOCLAW_SOURCE_ROOT/package.json" (use a more robust regex
like '"name":\s*"nemoclaw"'), invoke pre_extract_openclaw via spin with the
source root as the argument (spin ... pre_extract_openclaw "$1" _
"$NEMOCLAW_SOURCE_ROOT"), and ensure all subsequent npm steps (spin "Installing
NemoClaw dependencies", "Building NemoClaw CLI modules", "Building NemoClaw
plugin", "Linking NemoClaw CLI") are run with a cd into "$NEMOCLAW_SOURCE_ROOT"
(or otherwise pass that directory) so npm install, npm run, and npm link operate
on the selected checkout rather than the current working directory; reference
NEMOCLAW_SOURCE_ROOT, pre_extract_openclaw, and the spin invocations when making
the edits.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 89e1ce80-7696-4bbe-940d-5085639f4b1b
📒 Files selected for processing (3)
install.shscripts/install.shtest/install-preflight.test.js
🚧 Files skipped from review as they are similar to previous changes (1)
- test/install-preflight.test.js
Comment on lines
+109
to
119
| if has_payload_marker "$LOCAL_PAYLOAD"; then | ||
| # shellcheck source=/dev/null | ||
| . "$LOCAL_PAYLOAD" | ||
| fi | ||
|
|
||
| step 3 "Onboarding" | ||
| if command_exists nemoclaw; then | ||
| run_onboard | ||
| ONBOARD_RAN=true | ||
| if [[ "${BASH_SOURCE[0]:-}" == "$0" ]] || { [[ -z "${BASH_SOURCE[0]:-}" ]] && { [[ "$0" == "bash" ]] || [[ "$0" == "-bash" ]]; }; }; then | ||
| if has_payload_marker "$LOCAL_PAYLOAD"; then | ||
| main "$@" | ||
| else | ||
| warn "Skipping onboarding — this shell still cannot resolve 'nemoclaw'." | ||
| bootstrap_main "$@" | ||
| fi |
Contributor
There was a problem hiding this comment.
Don’t source a checkout-local payload during stdin installs.
When this script is read from stdin, SCRIPT_DIR resolves to the caller’s current directory, so LOCAL_PAYLOAD becomes ./scripts/install.sh. If that file exists and carries the marker, the bootstrap sources local disk content instead of cloning and executing the selected ref.
🛠️ Proposed fix
-if has_payload_marker "$LOCAL_PAYLOAD"; then
+if [[ "${BASH_SOURCE[0]:-}" == "$0" && "$0" != "bash" && "$0" != "-bash" ]] && has_payload_marker "$LOCAL_PAYLOAD"; then
# shellcheck source=/dev/null
. "$LOCAL_PAYLOAD"
fi
@@
- if has_payload_marker "$LOCAL_PAYLOAD"; then
+ if [[ "${BASH_SOURCE[0]:-}" == "$0" && "$0" != "bash" && "$0" != "-bash" ]] && has_payload_marker "$LOCAL_PAYLOAD"; then
main "$@"
else
bootstrap_main "$@"
fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if has_payload_marker "$LOCAL_PAYLOAD"; then | |
| # shellcheck source=/dev/null | |
| . "$LOCAL_PAYLOAD" | |
| fi | |
| step 3 "Onboarding" | |
| if command_exists nemoclaw; then | |
| run_onboard | |
| ONBOARD_RAN=true | |
| if [[ "${BASH_SOURCE[0]:-}" == "$0" ]] || { [[ -z "${BASH_SOURCE[0]:-}" ]] && { [[ "$0" == "bash" ]] || [[ "$0" == "-bash" ]]; }; }; then | |
| if has_payload_marker "$LOCAL_PAYLOAD"; then | |
| main "$@" | |
| else | |
| warn "Skipping onboarding — this shell still cannot resolve 'nemoclaw'." | |
| bootstrap_main "$@" | |
| fi | |
| if [[ "${BASH_SOURCE[0]:-}" == "$0" && "$0" != "bash" && "$0" != "-bash" ]] && has_payload_marker "$LOCAL_PAYLOAD"; then | |
| # shellcheck source=/dev/null | |
| . "$LOCAL_PAYLOAD" | |
| fi | |
| if [[ "${BASH_SOURCE[0]:-}" == "$0" ]] || { [[ -z "${BASH_SOURCE[0]:-}" ]] && { [[ "$0" == "bash" ]] || [[ "$0" == "-bash" ]]; }; }; then | |
| if [[ "${BASH_SOURCE[0]:-}" == "$0" && "$0" != "bash" && "$0" != "-bash" ]] && has_payload_marker "$LOCAL_PAYLOAD"; then | |
| main "$@" | |
| else | |
| bootstrap_main "$@" | |
| fi | |
| fi |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@install.sh` around lines 109 - 119, The current logic sources LOCAL_PAYLOAD
even when the installer is read from stdin, causing local checkout payloads to
be used; change the sourcing guard around has_payload_marker/LOCAL_PAYLOAD so it
only sources when the script is being executed from a real file (i.e.,
BASH_SOURCE[0] refers to an existing readable file and is not the stdin/built-in
shell invocation), and ensure the runtime dispatch that calls main vs
bootstrap_main uses the same “script is a real file” test; update the checks
around has_payload_marker, LOCAL_PAYLOAD, BASH_SOURCE, main, and bootstrap_main
so stdin installs never source the local payload.
cv
approved these changes
Apr 3, 2026
cjagwani
pushed a commit
to fdzdev/NemoClaw
that referenced
this pull request
Apr 3, 2026
## Summary - turn the repo-root `install.sh` into a thin bootstrap that selects one install ref and then executes installer logic from that same ref - reuse `scripts/install.sh` as the versioned installer payload instead of adding another installer path - preserve compatibility for older refs by only treating `scripts/install.sh` as the payload when it contains an explicit payload marker; otherwise fall back to the cloned root `install.sh` ## Validation - `node_modules/.bin/vitest run test/install-preflight.test.js` - `bash -n install.sh scripts/install.sh` - `npx eslint test/install-preflight.test.js` ## Notes - keeps `curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash` working - keeps direct repo-checkout execution working for both `bash install.sh` and `bash scripts/install.sh` - adds explicit coverage for `curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash` - pushed update at `46ad602`; repo pre-push still has an unrelated failure in `src/lib/preflight.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reworked the installer into a lightweight bootstrap that selects and runs a versioned payload, simplifying controls and validation for a faster, more reliable install experience. * Streamlined error/output styling and download verification to reduce noise. * **New Features** * Self-contained, versioned installer option with built-in Node.js setup, conditional GPU tooling/model handling, and improved onboarding/resume and PATH guidance. * **Tests** * Updated end-to-end tests to cover bootstrap paths, payload execution, and non-clone install scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
lakamsani
pushed a commit
to lakamsani/NemoClaw
that referenced
this pull request
Apr 4, 2026
## Summary - turn the repo-root `install.sh` into a thin bootstrap that selects one install ref and then executes installer logic from that same ref - reuse `scripts/install.sh` as the versioned installer payload instead of adding another installer path - preserve compatibility for older refs by only treating `scripts/install.sh` as the payload when it contains an explicit payload marker; otherwise fall back to the cloned root `install.sh` ## Validation - `node_modules/.bin/vitest run test/install-preflight.test.js` - `bash -n install.sh scripts/install.sh` - `npx eslint test/install-preflight.test.js` ## Notes - keeps `curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash` working - keeps direct repo-checkout execution working for both `bash install.sh` and `bash scripts/install.sh` - adds explicit coverage for `curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash` - pushed update at `46ad602`; repo pre-push still has an unrelated failure in `src/lib/preflight.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reworked the installer into a lightweight bootstrap that selects and runs a versioned payload, simplifying controls and validation for a faster, more reliable install experience. * Streamlined error/output styling and download verification to reduce noise. * **New Features** * Self-contained, versioned installer option with built-in Node.js setup, conditional GPU tooling/model handling, and improved onboarding/resume and PATH guidance. * **Tests** * Updated end-to-end tests to cover bootstrap paths, payload execution, and non-clone install scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
ericksoa
pushed a commit
that referenced
this pull request
Apr 4, 2026
…ty (#1470) ## Summary - unify installer and onboarding host detection around shared TypeScript preflight logic - move `deploy` behavior into TypeScript, thin the Brev compatibility wrapper, and harden Brev readiness handling - demote or remove legacy platform-specific setup paths (`setup-spark`, `brev-setup.sh`) in favor of the canonical installer + onboard flow - update docs, CLI help, and Brev E2E coverage to match the new behavior ## What Changed - added shared host assessment and remediation planning in `src/lib/preflight.ts` - wired installer and onboard flows to the same host preflight decisions - changed Podman handling from hard block to unsupported-runtime warning - migrated deploy logic into `src/lib/deploy.ts` - updated `nemoclaw deploy` to use the authenticated Brev CLI, current Brev create flags, explicit GCP provider default, stricter readiness checks, and standard installer/onboard flow - removed `scripts/setup-spark.sh` and reduced `scripts/brev-setup.sh` to a deprecated compatibility wrapper - updated README/docs/help text and hardened the Brev E2E cleanup path ## Validation - `npm run build:cli` - targeted Vitest coverage for `src/lib/preflight.test.ts`, `src/lib/deploy.test.ts`, `test/install-preflight.test.js`, `test/cli.test.js`, `test/runner.test.js` - live Brev validation with `TEST_SUITE=deploy-cli` on `cpu-e2.4vcpu-16gb` - confirmed successful end-to-end remote deploy after waiting for Brev `status=RUNNING`, `build_status=COMPLETED`, `shell_status=READY` ## Related Issues - Fixes #1377 - Addresses #1330 - Addresses #1390 - Related to #1404 ## Credit / Prior Work This branch builds on ideas and prior work from: - #1368 by @zyang-dev for simplifying Spark setup and removing the old cgroup workaround - #1395 and #1468 by @kjw3 for the thin installer/bootstrap direction and installer path reliability - #1450 by @cjagwani for switching Brev flows toward GCP for reliability - #1383 by @13ernkastel for the current Brev create flag compatibility work - #1364 by @WuKongAI-CMU for deploy sync-path fixes - #1362 and #1266 by @jyaunches for the Brev E2E/launchable infrastructure direction - issue ideas from #1377 and #1404 by @zNeill, #1330 by @Marcelo5444, and #1390 by @ericksoa <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Improved host diagnostics with actionable remediation guidance surfaced during installer/onboard preflight. * **Improvements** * macOS (Intel) now recommends Docker Desktop; DGX Spark guidance now uses the standard installer + `nemoclaw onboard`. * Preflight output shows detected runtime and WSL notes; installer prints remediation actions and will skip onboarding on blocking issues. * **Deprecations** * `nemoclaw deploy`, `nemoclaw setup-spark`, and the legacy bootstrap wrapper are now deprecated compatibility paths. * **Documentation** * Quickstart, troubleshooting, and command reference updated to reflect installer+onboard flow and deprecation guidance. * **Tests** * Added/updated tests covering preflight, deploy compatibility, CLI aliases, and deploy e2e scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
tommylin-signalpro
pushed a commit
to tommylin-signalpro/NemoClaw
that referenced
this pull request
Apr 7, 2026
## Summary - turn the repo-root `install.sh` into a thin bootstrap that selects one install ref and then executes installer logic from that same ref - reuse `scripts/install.sh` as the versioned installer payload instead of adding another installer path - preserve compatibility for older refs by only treating `scripts/install.sh` as the payload when it contains an explicit payload marker; otherwise fall back to the cloned root `install.sh` ## Validation - `node_modules/.bin/vitest run test/install-preflight.test.js` - `bash -n install.sh scripts/install.sh` - `npx eslint test/install-preflight.test.js` ## Notes - keeps `curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash` working - keeps direct repo-checkout execution working for both `bash install.sh` and `bash scripts/install.sh` - adds explicit coverage for `curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash` - pushed update at `46ad602`; repo pre-push still has an unrelated failure in `src/lib/preflight.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reworked the installer into a lightweight bootstrap that selects and runs a versioned payload, simplifying controls and validation for a faster, more reliable install experience. * Streamlined error/output styling and download verification to reduce noise. * **New Features** * Self-contained, versioned installer option with built-in Node.js setup, conditional GPU tooling/model handling, and improved onboarding/resume and PATH guidance. * **Tests** * Updated end-to-end tests to cover bootstrap paths, payload execution, and non-clone install scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
tommylin-signalpro
pushed a commit
to tommylin-signalpro/NemoClaw
that referenced
this pull request
Apr 7, 2026
## Summary - turn the repo-root `install.sh` into a thin bootstrap that selects one install ref and then executes installer logic from that same ref - reuse `scripts/install.sh` as the versioned installer payload instead of adding another installer path - preserve compatibility for older refs by only treating `scripts/install.sh` as the payload when it contains an explicit payload marker; otherwise fall back to the cloned root `install.sh` ## Validation - `node_modules/.bin/vitest run test/install-preflight.test.js` - `bash -n install.sh scripts/install.sh` - `npx eslint test/install-preflight.test.js` ## Notes - keeps `curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash` working - keeps direct repo-checkout execution working for both `bash install.sh` and `bash scripts/install.sh` - adds explicit coverage for `curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash` - pushed update at `46ad602`; repo pre-push still has an unrelated failure in `src/lib/preflight.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reworked the installer into a lightweight bootstrap that selects and runs a versioned payload, simplifying controls and validation for a faster, more reliable install experience. * Streamlined error/output styling and download verification to reduce noise. * **New Features** * Self-contained, versioned installer option with built-in Node.js setup, conditional GPU tooling/model handling, and improved onboarding/resume and PATH guidance. * **Tests** * Updated end-to-end tests to cover bootstrap paths, payload execution, and non-clone install scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
gemini2026
pushed a commit
to gemini2026/NemoClaw
that referenced
this pull request
Apr 14, 2026
## Summary - turn the repo-root `install.sh` into a thin bootstrap that selects one install ref and then executes installer logic from that same ref - reuse `scripts/install.sh` as the versioned installer payload instead of adding another installer path - preserve compatibility for older refs by only treating `scripts/install.sh` as the payload when it contains an explicit payload marker; otherwise fall back to the cloned root `install.sh` ## Validation - `node_modules/.bin/vitest run test/install-preflight.test.js` - `bash -n install.sh scripts/install.sh` - `npx eslint test/install-preflight.test.js` ## Notes - keeps `curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash` working - keeps direct repo-checkout execution working for both `bash install.sh` and `bash scripts/install.sh` - adds explicit coverage for `curl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash` - pushed update at `46ad602`; repo pre-push still has an unrelated failure in `src/lib/preflight.test.ts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reworked the installer into a lightweight bootstrap that selects and runs a versioned payload, simplifying controls and validation for a faster, more reliable install experience. * Streamlined error/output styling and download verification to reduce noise. * **New Features** * Self-contained, versioned installer option with built-in Node.js setup, conditional GPU tooling/model handling, and improved onboarding/resume and PATH guidance. * **Tests** * Updated end-to-end tests to cover bootstrap paths, payload execution, and non-clone install scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
gemini2026
pushed a commit
to gemini2026/NemoClaw
that referenced
this pull request
Apr 14, 2026
…ty (NVIDIA#1470) ## Summary - unify installer and onboarding host detection around shared TypeScript preflight logic - move `deploy` behavior into TypeScript, thin the Brev compatibility wrapper, and harden Brev readiness handling - demote or remove legacy platform-specific setup paths (`setup-spark`, `brev-setup.sh`) in favor of the canonical installer + onboard flow - update docs, CLI help, and Brev E2E coverage to match the new behavior ## What Changed - added shared host assessment and remediation planning in `src/lib/preflight.ts` - wired installer and onboard flows to the same host preflight decisions - changed Podman handling from hard block to unsupported-runtime warning - migrated deploy logic into `src/lib/deploy.ts` - updated `nemoclaw deploy` to use the authenticated Brev CLI, current Brev create flags, explicit GCP provider default, stricter readiness checks, and standard installer/onboard flow - removed `scripts/setup-spark.sh` and reduced `scripts/brev-setup.sh` to a deprecated compatibility wrapper - updated README/docs/help text and hardened the Brev E2E cleanup path ## Validation - `npm run build:cli` - targeted Vitest coverage for `src/lib/preflight.test.ts`, `src/lib/deploy.test.ts`, `test/install-preflight.test.js`, `test/cli.test.js`, `test/runner.test.js` - live Brev validation with `TEST_SUITE=deploy-cli` on `cpu-e2.4vcpu-16gb` - confirmed successful end-to-end remote deploy after waiting for Brev `status=RUNNING`, `build_status=COMPLETED`, `shell_status=READY` ## Related Issues - Fixes NVIDIA#1377 - Addresses NVIDIA#1330 - Addresses NVIDIA#1390 - Related to NVIDIA#1404 ## Credit / Prior Work This branch builds on ideas and prior work from: - NVIDIA#1368 by @zyang-dev for simplifying Spark setup and removing the old cgroup workaround - NVIDIA#1395 and NVIDIA#1468 by @kjw3 for the thin installer/bootstrap direction and installer path reliability - NVIDIA#1450 by @cjagwani for switching Brev flows toward GCP for reliability - NVIDIA#1383 by @13ernkastel for the current Brev create flag compatibility work - NVIDIA#1364 by @WuKongAI-CMU for deploy sync-path fixes - NVIDIA#1362 and NVIDIA#1266 by @jyaunches for the Brev E2E/launchable infrastructure direction - issue ideas from NVIDIA#1377 and NVIDIA#1404 by @zNeill, NVIDIA#1330 by @Marcelo5444, and NVIDIA#1390 by @ericksoa <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Improved host diagnostics with actionable remediation guidance surfaced during installer/onboard preflight. * **Improvements** * macOS (Intel) now recommends Docker Desktop; DGX Spark guidance now uses the standard installer + `nemoclaw onboard`. * Preflight output shows detected runtime and WSL notes; installer prints remediation actions and will skip onboarding on blocking issues. * **Deprecations** * `nemoclaw deploy`, `nemoclaw setup-spark`, and the legacy bootstrap wrapper are now deprecated compatibility paths. * **Documentation** * Quickstart, troubleshooting, and command reference updated to reflect installer+onboard flow and deprecation guidance. * **Tests** * Added/updated tests covering preflight, deploy compatibility, CLI aliases, and deploy e2e scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shinto a thin bootstrap that selects one install ref and then executes installer logic from that same refscripts/install.shas the versioned installer payload instead of adding another installer pathscripts/install.shas the payload when it contains an explicit payload marker; otherwise fall back to the cloned rootinstall.shValidation
node_modules/.bin/vitest run test/install-preflight.test.jsbash -n install.sh scripts/install.shnpx eslint test/install-preflight.test.jsNotes
curl -fsSL https://www.nvidia.com/nemoclaw.sh | bashworkingbash install.shandbash scripts/install.shcurl -fsSL https://www.nvidia.com/nemoclaw.sh | NEMOCLAW_INSTALL_TAG=v0.0.1 bash46ad602; repo pre-push still has an unrelated failure insrc/lib/preflight.test.tsSummary by CodeRabbit
Refactor
New Features
Tests