fix(cli): classifyGatewayStatus no longer misclassifies "Not connected" by cv · Pull Request #1288 · NVIDIA/NemoClaw

cv · 2026-04-02T00:49:48Z

Summary

The classifyGatewayStatus regex matched "Not connected" as connected because \bConnected\b matches the substring. This was partially fixed in #1268 (added Disconnected guard) but "Not connected" still slipped through.

Fix:

Move unavailable-pattern check before connected check
Use strict line-anchored regex: /^\s*(?:Status:\s*)?Connected\s*$/im
Add regression tests for "Status: Not connected" → inactive

This fix was intended for #1268 but the auto-merge squashed before the commit landed.

Fixes #1279.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved gateway connection status detection to handle edge cases and properly classify various status formats, ensuring more accurate connection state reporting.
Tests
- Added test coverage for additional gateway status variations.

Move the unavailable-pattern check before the connected check, and use a strict line-anchored regex (/^\s*(?:Status:\s*)?Connected\s*$/im) so "Not connected", "Disconnected", and other substrings no longer match. Add regression tests for "Status: Not connected" and bare "Connected". Fixes #1279. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-04-02T00:50:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cc5b4fe-0727-4c50-83bf-264bbe431579

📥 Commits

Reviewing files that changed from the base of the PR and between c3fd887 and 9ff4d10.

📒 Files selected for processing (2)

src/lib/runtime-recovery.test.ts
src/lib/runtime-recovery.ts

📝 Walkthrough

Walkthrough

The changes fix a bug where gateway status strings containing "Not connected" were misclassified as "connected". The regex pattern for detecting a connected state is now stricter, requiring the word "Connected" to appear alone (optionally prefixed with "Status:") rather than as part of a larger phrase, with corresponding test coverage.

Changes

Cohort / File(s)	Summary
Gateway Status Classification Bug Fix `src/lib/runtime-recovery.ts`, `src/lib/runtime-recovery.test.ts`	Updated `classifyGatewayStatus` to use stricter regex `/^\s(?:Status:\s)?Connected\s*$/im` that matches only when "Connected" appears alone (not within "Not connected"). Added regression test cases for `"Status: Not connected"` → `"inactive"` and `"Connected"` → `"connected"`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A gateway once fibbed 'bout its health and state,
"Not connected" pretended it was great!
A rabbit fixed the regex, precise and clean,
Now true is true, and false is clearly seen! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main fix: preventing misclassification of 'Not connected' by the classifyGatewayStatus function.
Linked Issues check	✅ Passed	The PR successfully implements all objectives from issue `#1279`: stricter connected regex, unavailable check priority, and regression tests for edge cases.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the classifyGatewayStatus function and adding regression tests, with no unrelated modifications present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cv/fix-classify-gateway-not-connected

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ericksoa

Clean fix for #1279. LGTM.

…d" (#1288) ## Summary The `classifyGatewayStatus` regex matched "Not connected" as connected because `\bConnected\b` matches the substring. This was partially fixed in #1268 (added Disconnected guard) but "Not connected" still slipped through. Fix: - Move unavailable-pattern check before connected check - Use strict line-anchored regex: `/^\s*(?:Status:\s*)?Connected\s*$/im` - Add regression tests for "Status: Not connected" → inactive This fix was intended for #1268 but the auto-merge squashed before the commit landed. Fixes #1279. 🤖 Generated with [Claude Code](https://claude.com/claude-code)  ## Summary by CodeRabbit * **Bug Fixes** * Improved gateway connection status detection to handle edge cases and properly classify various status formats, ensuring more accurate connection state reporting. * **Tests** * Added test coverage for additional gateway status variations.  Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…d" (NVIDIA#1288) ## Summary The `classifyGatewayStatus` regex matched "Not connected" as connected because `\bConnected\b` matches the substring. This was partially fixed in NVIDIA#1268 (added Disconnected guard) but "Not connected" still slipped through. Fix: - Move unavailable-pattern check before connected check - Use strict line-anchored regex: `/^\s*(?:Status:\s*)?Connected\s*$/im` - Add regression tests for "Status: Not connected" → inactive This fix was intended for NVIDIA#1268 but the auto-merge squashed before the commit landed. Fixes NVIDIA#1279. 🤖 Generated with [Claude Code](https://claude.com/claude-code)  ## Summary by CodeRabbit * **Bug Fixes** * Improved gateway connection status detection to handle edge cases and properly classify various status formats, ensuring more accurate connection state reporting. * **Tests** * Added test coverage for additional gateway status variations.  Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cv enabled auto-merge (squash) April 2, 2026 00:53

Merge branch 'main' into cv/fix-classify-gateway-not-connected

9d723cb

ericksoa approved these changes Apr 2, 2026

View reviewed changes

cv merged commit b999c0e into main Apr 2, 2026
8 checks passed

cv deleted the cv/fix-classify-gateway-not-connected branch May 27, 2026 21:16

wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): classifyGatewayStatus no longer misclassifies "Not connected"#1288

fix(cli): classifyGatewayStatus no longer misclassifies "Not connected"#1288
cv merged 2 commits into
mainfrom
cv/fix-classify-gateway-not-connected

cv commented Apr 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 2, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

ericksoa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cv commented Apr 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

ericksoa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cv commented Apr 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 2, 2026 •

edited

Loading