fix(onboard): add skipVerify to NVIDIA provider config by latenighthackathon · Pull Request #1133 · NVIDIA/NemoClaw

latenighthackathon · 2026-03-31T02:08:51Z

Summary

The NVIDIA provider (build) in REMOTE_PROVIDER_CONFIG is the only remote provider missing the skipVerify flag. This causes openshell inference set to attempt endpoint verification during onboarding, which fails even when the API is reachable from the host — blocking onboarding completely at step 4/7.

All other providers (OpenAI, Anthropic, Gemini, custom) already set skipVerify: true so that --no-verify is passed to the inference setup command. This adds the same flag to the NVIDIA provider for consistent behavior.

Changes

Added skipVerify: true to the build entry in REMOTE_PROVIDER_CONFIG (bin/lib/onboard.js)

Test Plan

Verified all other providers already include skipVerify: true
Confirmed skipVerify controls the --no-verify flag at line 2420
Ran full test suite: 650/653 passed (3 pre-existing failures in service-env.test.js unrelated to this change)

Closes #1130

Signed-off-by: latenighthackathon latenighthackathon@users.noreply.github.com

Summary by CodeRabbit

New Features
- Enabled skip verification support for the NVIDIA Endpoints provider during onboarding to allow optional bypass of certificate checks.
- Aligns NVIDIA provider onboarding behavior with other remote providers for a more consistent and smoother setup experience.
- Reduces setup friction when configuring remote inference endpoints that require relaxed verification.

The NVIDIA provider (build) in REMOTE_PROVIDER_CONFIG is the only remote provider missing the skipVerify flag. This causes `openshell inference set` to attempt endpoint verification during onboarding, which fails even when the API is reachable from the host — blocking onboarding at step 4/7. All other providers (OpenAI, Anthropic, Gemini, custom) already set skipVerify: true so that `--no-verify` is passed to the inference setup command. This adds the same flag to the NVIDIA provider for consistent behavior. Closes NVIDIA#1130 Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>

coderabbitai · 2026-03-31T02:09:06Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13fa166f-a8e3-46c9-a5fe-dbdb6fa27a58

📥 Commits

Reviewing files that changed from the base of the PR and between 2babb4d and a1a90f8.

📒 Files selected for processing (1)

bin/lib/onboard.js

📝 Walkthrough

Walkthrough

Added a single configuration flag (skipVerify: true) to the NVIDIA Endpoints (build) entry in REMOTE_PROVIDER_CONFIG, causing onboarding’s inference setup to skip endpoint verification for that provider.

Changes

Cohort / File(s)	Summary
NVIDIA Provider Configuration `bin/lib/onboard.js`	Added `skipVerify: true` to the `build` provider entry in `REMOTE_PROVIDER_CONFIG` so `openshell inference set` will include `--no-verify` for NVIDIA endpoints.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I found a flag, tucked neat and small,
skipVerify set — no more stalled call.
NVIDIA gates now open wide,
onboarding hops in with pride.
✨ One tiny tweak, the path made all.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding the skipVerify flag to the NVIDIA provider configuration.
Linked Issues check	✅ Passed	The PR directly addresses all coding requirements from issue `#1130`: adding skipVerify: true to REMOTE_PROVIDER_CONFIG.build to enable --no-verify flag during inference setup.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to adding skipVerify: true to the NVIDIA provider config, directly addressing the root cause identified in issue `#1130`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

bin/lib/onboard.js (1)
78-97: ⚠️ Potential issue | 🟠 Major

Add skipVerify: true to Anthropic provider configs to match other providers.

The anthropic and anthropicCompatible provider configs (lines 78–97) are missing skipVerify: true, while build, openai, gemini, and custom all include it. This inconsistency means Anthropic users may encounter endpoint verification failures during onboarding—the same issue this PR fixes for NVIDIA. Either add skipVerify: true to both Anthropic entries, or clarify in the PR summary why Anthropic verification should be required when other providers skip it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bin/lib/onboard.js` around lines 78 - 97, The Anthropic provider objects
anthropic and anthropicCompatible are missing the skipVerify flag causing
inconsistent endpoint verification behavior; update both provider config objects
(anthropic and anthropicCompatible) to include skipVerify: true so they match
other providers (build, openai, gemini, custom) and avoid verification failures
during onboarding.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@bin/lib/onboard.js`:
- Around line 78-97: The Anthropic provider objects anthropic and
anthropicCompatible are missing the skipVerify flag causing inconsistent
endpoint verification behavior; update both provider config objects (anthropic
and anthropicCompatible) to include skipVerify: true so they match other
providers (build, openai, gemini, custom) and avoid verification failures during
onboarding.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1714b71-8257-493e-a248-f2339b982777

📥 Commits

Reviewing files that changed from the base of the PR and between ce03233 and 2babb4d.

📒 Files selected for processing (1)

bin/lib/onboard.js

latenighthackathon · 2026-04-01T00:43:35Z

Hi — the DCO check failure was caused by the Signed-off-by line being positioned after the CodeRabbit auto-generated block, which got truncated when the CI captured the PR body. I've moved the sign-off line above the CodeRabbit section so it's picked up correctly.

A new workflow run was triggered but needs maintainer approval to execute (first-time contributor gate). Could someone approve the pending run when you get a chance? Thanks!

## Summary The NVIDIA provider (`build`) in `REMOTE_PROVIDER_CONFIG` is the only remote provider missing the `skipVerify` flag. This causes `openshell inference set` to attempt endpoint verification during onboarding, which fails even when the API is reachable from the host — blocking onboarding completely at step 4/7. All other providers (OpenAI, Anthropic, Gemini, custom) already set `skipVerify: true` so that `--no-verify` is passed to the inference setup command. This adds the same flag to the NVIDIA provider for consistent behavior. ## Changes - Added `skipVerify: true` to the `build` entry in `REMOTE_PROVIDER_CONFIG` (`bin/lib/onboard.js`) ## Test Plan - [x] Verified all other providers already include `skipVerify: true` - [x] Confirmed `skipVerify` controls the `--no-verify` flag at line 2420 - [x] Ran full test suite: 650/653 passed (3 pre-existing failures in `service-env.test.js` unrelated to this change) Closes #1130 Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>  ## Summary by CodeRabbit * **New Features** * Enabled skip verification support for the NVIDIA Endpoints provider during onboarding, aligning its behavior with other remote providers for a more consistent setup experience.  Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: Carlos Villela <cvillela@nvidia.com>

## Summary The NVIDIA provider (`build`) in `REMOTE_PROVIDER_CONFIG` is the only remote provider missing the `skipVerify` flag. This causes `openshell inference set` to attempt endpoint verification during onboarding, which fails even when the API is reachable from the host — blocking onboarding completely at step 4/7. All other providers (OpenAI, Anthropic, Gemini, custom) already set `skipVerify: true` so that `--no-verify` is passed to the inference setup command. This adds the same flag to the NVIDIA provider for consistent behavior. ## Changes - Added `skipVerify: true` to the `build` entry in `REMOTE_PROVIDER_CONFIG` (`bin/lib/onboard.js`) ## Test Plan - [x] Verified all other providers already include `skipVerify: true` - [x] Confirmed `skipVerify` controls the `--no-verify` flag at line 2420 - [x] Ran full test suite: 650/653 passed (3 pre-existing failures in `service-env.test.js` unrelated to this change) Closes NVIDIA#1130 Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>  ## Summary by CodeRabbit * **New Features** * Enabled skip verification support for the NVIDIA Endpoints provider during onboarding, aligning its behavior with other remote providers for a more consistent setup experience.  Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: latenighthackathon <latenighthackathon@users.noreply.github.com> Co-authored-by: Carlos Villela <cvillela@nvidia.com>

coderabbitai Bot reviewed Mar 31, 2026

View reviewed changes

cv approved these changes Mar 31, 2026

View reviewed changes

Merge branch 'main' into fix/onboard-nvidia-skip-verify

a1a90f8

cv approved these changes Apr 1, 2026

View reviewed changes

cv merged commit 72e0d4e into NVIDIA:main Apr 1, 2026
3 of 4 checks passed

ericksoa mentioned this pull request Apr 20, 2026

test(cli): regression test for non-string gatewayName normalization #2112

Merged

1 task

latenighthackathon deleted the fix/onboard-nvidia-skip-verify branch May 18, 2026 05:10

wscurran added the bug-fix PR fixes a bug or regression label Jun 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(onboard): add skipVerify to NVIDIA provider config#1133

fix(onboard): add skipVerify to NVIDIA provider config#1133
cv merged 2 commits into
NVIDIA:mainfrom
latenighthackathon:fix/onboard-nvidia-skip-verify

latenighthackathon commented Mar 31, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 31, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

latenighthackathon commented Apr 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

latenighthackathon commented Mar 31, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

latenighthackathon commented Apr 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

latenighthackathon commented Mar 31, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 31, 2026 •

edited

Loading