TE fused grouped mlp with grouped bias and delayed wgrad#4095
Merged
yaox12 merged 4 commits intoApr 7, 2026
Merged
Conversation
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
yaox12
approved these changes
Apr 3, 2026
Member
|
/ok to test fcc1ce4 |
Member
|
/ok to test 64b57f0 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24059734998 |
Member
|
/claude copy |
svcnvidia-nemo-ci
added a commit
that referenced
this pull request
Apr 14, 2026
svcnvidia-nemo-ci
added a commit
that referenced
this pull request
Apr 14, 2026
5 tasks
|
🤖 This PR has been copied to main in #4288. |
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 7, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
3 tasks
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 7, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 8, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 11, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY
pushed a commit
to Connor-XY/Megatron-LM
that referenced
this pull request
May 13, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Xin Yao <xiny@nvidia.com> Co-authored-by: Xin Yao <xiny@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes the support for delayed wgrad compute for fused MLP path as well as adds support for the new grouped bias parameter in TE. Also introduces a check for the TE version that supports these features.
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.