Skip to content

TE fused grouped mlp with grouped bias and delayed wgrad#4095

Merged
yaox12 merged 4 commits into
NVIDIA:devfrom
ksivaman:te_fused_grouped_mlp_with_grouped_bias_and_delayed_wgrad
Apr 7, 2026
Merged

TE fused grouped mlp with grouped bias and delayed wgrad#4095
yaox12 merged 4 commits into
NVIDIA:devfrom
ksivaman:te_fused_grouped_mlp_with_grouped_bias_and_delayed_wgrad

Conversation

@ksivaman

@ksivaman ksivaman commented Apr 1, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

Fixes the support for delayed wgrad compute for fused MLP path as well as adds support for the new grouped bias parameter in TE. Also introduces a check for the TE version that supports these features.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman ksivaman requested review from WanZzzzzz and yaox12 April 1, 2026 19:12
@ksivaman ksivaman requested review from a team as code owners April 1, 2026 19:12
@copy-pr-bot

copy-pr-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12

yaox12 commented Apr 3, 2026

Copy link
Copy Markdown
Member

/ok to test fcc1ce4

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 3, 2026
yaox12 added 2 commits April 3, 2026 14:36
Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12

yaox12 commented Apr 3, 2026

Copy link
Copy Markdown
Member

/ok to test 64b57f0

@yaox12 yaox12 added this pull request to the merge queue Apr 7, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24059734998

Merged via the queue into NVIDIA:dev with commit ab6c0ff Apr 7, 2026
60 of 61 checks passed
@Phlip79

Phlip79 commented Apr 14, 2026

Copy link
Copy Markdown
Member

/claude copy

@svcnvidia-nemo-ci

Copy link
Copy Markdown

🤖 This PR has been copied to main in #4288.

Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 7, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 7, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 8, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 11, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 12, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Connor-XY pushed a commit to Connor-XY/Megatron-LM that referenced this pull request May 13, 2026
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants