Skip to content

Add NVIDIA-Nemotron-3-Super-120B-A12B-BF16 to ModelOpt examples#3805

Merged
Phlip79 merged 4 commits into
NVIDIA:mainfrom
jenchen13:jennifchen/super3_modleopt
Mar 11, 2026
Merged

Add NVIDIA-Nemotron-3-Super-120B-A12B-BF16 to ModelOpt examples#3805
Phlip79 merged 4 commits into
NVIDIA:mainfrom
jenchen13:jennifchen/super3_modleopt

Conversation

@jenchen13

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add NVIDIA-Nemotron-3-Super-120B-A12B-BF16 to ModelOpt examples

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 11, 2026 16:24
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Mar 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 11, 2026
@jenchen13 jenchen13 marked this pull request as ready for review March 11, 2026 16:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 11, 2026 16:27
@jenchen13 jenchen13 requested a review from AAnoosheh March 11, 2026 17:06
@Phlip79

Phlip79 commented Mar 11, 2026

Copy link
Copy Markdown
Member

/ok to test fa0f16a

@Phlip79

Phlip79 commented Mar 11, 2026

Copy link
Copy Markdown
Member

/claude review

@jenchen13

Copy link
Copy Markdown
Contributor Author

/claude review

@claude

claude Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

LGTM

@Phlip79 Phlip79 enabled auto-merge March 11, 2026 17:23
@Phlip79 Phlip79 removed the request for review from a team March 11, 2026 17:23
@Phlip79 Phlip79 added this pull request to the merge queue Mar 11, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22968373964

Merged via the queue into NVIDIA:main with commit 5bc89f3 Mar 11, 2026
54 of 55 checks passed
HollowMan6 pushed a commit to HollowMan6/Megatron-LM that referenced this pull request Mar 16, 2026
ilml added a commit to ilml/Megatron-LM that referenced this pull request Mar 20, 2026
… to ModelOpt examples (NVIDIA#3805)

New files:
  - examples/post_training/modelopt/conf/nvidia/NVIDIA-Nemotron-3-Super-120B-A12B-BF16.sh
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants