Skip to content

build: Bump TE2.13#3800

Merged
ko3n1g merged 7 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/build/bump-te-213
Mar 11, 2026
Merged

build: Bump TE2.13#3800
ko3n1g merged 7 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/build/bump-te-213

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@ko3n1g
build: Bump TE2.13
32ab8c2 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 11, 2026 10:40
@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Mar 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 11, 2026
@ko3n1g
test_wrong_cuda_graph_impl_returns_false
9b89d30 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Mar 11, 2026
Closed
@ko3n1g

ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@ko3n1g ko3n1g mentioned this pull request Mar 11, 2026
Closed
@ko3n1g
test_create_and_delete_cudagraphs
bb89f6b 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@ko3n1g
test_create_cudagraphs_multi_microbatch
30e0a37 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Mar 11, 2026
Closed
@ko3n1g

ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@ko3n1g
test_pp2_create_cudagraphs_first_stage
1844895 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Mar 11, 2026
Closed
@ko3n1g

ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@ko3n1g
update golden values
bc9e947 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@ko3n1g ko3n1g marked this pull request as ready for review March 11, 2026 16:50
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 11, 2026 16:51
@ko3n1g
update
99b3dd3 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g enabled auto-merge March 11, 2026 18:51
@ko3n1g ko3n1g added this pull request to the merge queue Mar 11, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Mar 11, 2026

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22970223933

Merged via the queue into NVIDIA:main with commit da46946 Mar 11, 2026
119 of 120 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/bump-te-213 branch March 11, 2026 20:38
ericharper
ericharper reviewed Mar 11, 2026
View reviewed changes
Comment thread pyproject.toml
{ git = "https://github.com/deepseek-ai/FlashMLA", rev = "9edee0c022cd0938148a18e334203b0aab43aa19" },
]
transformer-engine = { git = "https://github.com/NVIDIA/TransformerEngine.git", rev = "5671fd3675906cda1ade26c24a65d3dedd88eb89" }
transformer-engine = { git = "https://github.com/NVIDIA/TransformerEngine.git", rev = "287770466f0f4433052260a765db5ff7b8be1320" }

@ericharper ericharper Mar 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be updated as well?

https://github.com/ko3n1g/Megatron-LM/blob/99b3dd31388f573d69957f39f44da0f85acff53e/pyproject.toml#L92

@ko3n1g ko3n1g Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! This doesn't affect CI, but for PyPi users we should still fix it. Will open a followup PR

@chtruong814 chtruong814 mentioned this pull request Mar 13, 2026
Merged
5 tasks
HollowMan6 pushed a commit to HollowMan6/Megatron-LM that referenced this pull request Mar 16, 2026
@ko3n1g @HollowMan6
build: Bump TE2.13 (NVIDIA#3800)
b7e6659 
Signed-off-by: oliver könig <okoenig@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
@ko3n1g
build: Bump TE2.13 (NVIDIA#3800)
cff8fcf 
Signed-off-by: oliver könig <okoenig@nvidia.com>
This was referenced May 26, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericharper ericharper ericharper left review comments

@thomasdhc thomasdhc thomasdhc approved these changes

Assignees

No one assigned

Labels

complexity: high Run functional tests

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

4 participants

@ko3n1g @svcnvidia-nemo-ci @thomasdhc @ericharper