ci: Repeat func tests, save logs of unit tests and lessen debug output#3089
Merged
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test 358e3e9 |
358e3e9 to
d3e34ea
Compare
chtruong814
approved these changes
Jan 27, 2026
chtruong814
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. Only had questions to understand better.
| else | ||
| ARGS=( | ||
| --scope mr-github-slim | ||
| --n-repeat 5 |
Contributor
There was a problem hiding this comment.
Roughly speaking, how much does this add to the CI time for one of those jobs?
Contributor
Author
There was a problem hiding this comment.
Around 15-20min per job.
| "N_REPEAT": "1", | ||
| "N_REPEAT": str(n_repeat), | ||
| "CLUSTER": "dgxh100_dgxc", | ||
| "NCCL_DEBUG": "INFO", |
Contributor
There was a problem hiding this comment.
What would show up when we encounter the random nccl failures again?
Contributor
Author
There was a problem hiding this comment.
Let me try if we can find a middle ground by using NCCL_DEBUG_FILE.
Contributor
Author
There was a problem hiding this comment.
We send NCCL debug now to file which we can later download from the job outputs
Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
added a commit
to ko3n1g/Megatron-LM
that referenced
this pull request
Jan 28, 2026
NVIDIA#3089) Signed-off-by: oliver könig <okoenig@nvidia.com>
6 tasks
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
NVIDIA#3089) Signed-off-by: oliver könig <okoenig@nvidia.com>
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
NVIDIA#3089) Signed-off-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.