Skip to content

[dev] perf(moe): Refine gated delta net implementation#3040

Merged
BestJuly merged 1 commit into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/refine_gdn_impl
Feb 2, 2026
Merged

[dev] perf(moe): Refine gated delta net implementation#3040
BestJuly merged 1 commit into
NVIDIA:devfrom
yuzhongw-nvidia:yuzhongw/refine_gdn_impl

Conversation

@yuzhongw-nvidia

@yuzhongw-nvidia yuzhongw-nvidia commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

PR for main #3042

Changes

  1. Switch to FLA conv1d. Benefits:
    • FLA conv1d accepts [b, s, h] shaped input, which helps us eliminate 1 transpose op.
    • FLA conv1d supports cu_seqlens arg, which is necessary for one of our future works, sequence packing.
    • FLA conv1d supports initial states, which is necessary for one of our future works, chunked PP.
  2. Combine l2norm to query and key to eliminate 1 × elementwise_kernel.

E2E correctness is checked as follows. (baseline is in pink, the new impl is in blue)
image

Perf gain

Model: Qwen3-Next-80B-A3B

E2E perf gain: ~1.04x

Timelines:

Baseline GDN forward (1.79 ms, redundant ops are in red boxes)
image

Optimized GDN forward (1.49 ms)
image

Baseline GDN backward (3.24 ms, the redundant op is in the red box)
image

Optimized GDN backward (3.01 ms)
image

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia yuzhongw-nvidia requested review from a team as code owners January 22, 2026 07:25
@copy-pr-bot

copy-pr-bot Bot commented Jan 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia yuzhongw-nvidia requested a review from a team January 22, 2026 07:29
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 4123fb6

@BestJuly BestJuly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BestJuly BestJuly added this pull request to the merge queue Feb 2, 2026
Merged via the queue into NVIDIA:dev with commit 0f73a8a Feb 2, 2026
70 of 74 checks passed
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
…NVIDIA#3040, NVIDIA#3220)

- Add context parallel (CP) support to GatedDeltaNet via all-to-all
  communication (tensor_a2a_cp2hp / tensor_a2a_hp2cp)
- Refine GDN implementation: replace causal_conv1d_fn with fla.modules.convolution,
  extract _prepare_qkv_for_gated_delta_rule and _compute_g_and_beta as @jit_fuser methods
- Update TransformerConfig to remove CP==1 assertion for gated_delta_net
  and add linear_attention_type deprecation alias
- Enable CP test cases in test_gated_delta_net.py and refactor correctness
  test to use shared _test_parallel_attention_correctness helper

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Mar 24, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 7, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 10, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 13, 2026
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants