Skip to content

Support EP with HSDP#2840

Merged
shjwudp merged 13 commits into
NVIDIA:mainfrom
wplf:jinliang/hsdp-ep-main
Feb 4, 2026
Merged

Support EP with HSDP#2840
shjwudp merged 13 commits into
NVIDIA:mainfrom
wplf:jinliang/hsdp-ep-main

Conversation

@wplf

@wplf wplf commented Jan 7, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

dev PR: #2800

This MR adds HSDP support for Expert Parallelism. With this change, DeepSeek‑v3 and other MoE models can be trained using M‑FSDP as well as HSDP+EP. HSDP enables better use of local bandwidth within a larger nvlink domain.

We ran convergence tests on the DeepSeek Proxy model. model. The experiments were based on the latest dev branch, with an additional patch that fixes MoE checkpoint save/load.

To validate the correctness of HSDP+EP, we loaded an FSDP+EP checkpoint at step 100 and resumed training with HSDP+EP. The loss curves and gradient norms matched closely.

image image f748c47e86d949904ac404d41dd1506c

For example, to use HSDP=2 and EP size=2, you need to add these argument to your script

--num-distributed-optimizer-instances 2 \
--outer-dp-sharding-strategy optim
--expert-model-parallel-size 2 

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @megatron-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @megatron-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@wplf wplf requested review from a team as code owners January 7, 2026 06:24
@copy-pr-bot

copy-pr-bot Bot commented Jan 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot requested a review from Phlip79 January 7, 2026 06:25
@wplf wplf mentioned this pull request Jan 7, 2026
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Jan 11, 2026
@erhoo82 erhoo82 added the dev2main: mbridge dev to main: this PR is needed in main for mbridge label Jan 21, 2026
@shjwudp shjwudp changed the title [Dev] Support EP with HSDP Support EP with HSDP Jan 22, 2026
@shjwudp

shjwudp commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

/ok to test 146425a

@shjwudp

shjwudp commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Hi @wplf , could you please fix the lint issue and synchronize the code with the PR-2800? thanks.

@wplf

wplf commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

Hi @wplf , could you please fix the lint issue and synchronize the code with the PR-2800? thanks.

OKK, I'll do it right now.

@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Jan 22, 2026
@wplf wplf force-pushed the jinliang/hsdp-ep-main branch from 8dc1f38 to 146425a Compare January 22, 2026 08:14
@wplf wplf force-pushed the jinliang/hsdp-ep-main branch from 8dc1f38 to 353d7d8 Compare January 22, 2026 08:26
@shjwudp shjwudp added Final Review PR is in the "final review" stage and removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Jan 30, 2026
@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Feb 1, 2026
@Phlip79

Phlip79 commented Feb 3, 2026

Copy link
Copy Markdown
Member

/ok to test 066ee8b

@chtruong814 chtruong814 removed the needs-follow-up Issue needs follow-up label Feb 4, 2026
@shjwudp shjwudp enabled auto-merge February 4, 2026 04:00
@shjwudp shjwudp added this pull request to the merge queue Feb 4, 2026
Merged via the queue into NVIDIA:main with commit 473e283 Feb 4, 2026
71 of 75 checks passed
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: jinliangl <jinliangl@nvidia.com>
Co-authored-by: Jinliang Li <jinliangl@pool0-01676.cm.cluster>
Co-authored-by: Jinliang Li <jinliangl@cw-dfw-cs-001-vscode-01.cm.cluster>
@wplf wplf deleted the jinliang/hsdp-ep-main branch March 12, 2026 02:22
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: jinliangl <jinliangl@nvidia.com>
Co-authored-by: Jinliang Li <jinliangl@pool0-01676.cm.cluster>
Co-authored-by: Jinliang Li <jinliangl@cw-dfw-cs-001-vscode-01.cm.cluster>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: medium dev2main: mbridge dev to main: this PR is needed in main for mbridge Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants