Skip to content

[main] feat(moe): Support moe shared expert gate for Qwen3-Next (2/4)#2751

Merged
Phlip79 merged 3 commits into
NVIDIA:mainfrom
yuzhongw-nvidia:shared_expert_gate
Jan 9, 2026
Merged

[main] feat(moe): Support moe shared expert gate for Qwen3-Next (2/4)#2751
Phlip79 merged 3 commits into
NVIDIA:mainfrom
yuzhongw-nvidia:shared_expert_gate

Conversation

@yuzhongw-nvidia

@yuzhongw-nvidia yuzhongw-nvidia commented Dec 24, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

MR to dev.

Design doc

Qwen3-Next functionality PRs.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia yuzhongw-nvidia requested review from a team as code owners December 24, 2025 06:02
@copy-pr-bot

copy-pr-bot Bot commented Dec 24, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 475951d

@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 24, 2025
@yuzhongw-nvidia yuzhongw-nvidia added module: moe Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. dev2main: mbridge dev to main: this PR is needed in main for mbridge labels Jan 6, 2026
Comment thread megatron/core/transformer/transformer_config.py Outdated
@Phlip79 Phlip79 requested review from ericharper and removed request for deepakn94 January 7, 2026 05:25
Co-authored-by: Philip Petrakian <pgpetrak@gmail.com>
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test e68ec68

Comment thread megatron/core/transformer/transformer_config.py Outdated
Co-authored-by: Philip Petrakian <pgpetrak@gmail.com>
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test f63b9d0

ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Jan 8, 2026
@Phlip79 Phlip79 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into NVIDIA:main with commit bddd0a8 Jan 9, 2026
70 of 76 checks passed
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 20, 2026
@yuzhongw-nvidia yuzhongw-nvidia deleted the shared_expert_gate branch February 4, 2026 07:45
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low dev2main: mbridge dev to main: this PR is needed in main for mbridge Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: moe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants