Reopen qwen3next functional test in lightweight mode#2493
Merged
Conversation
Contributor
Author
|
/ok to test f41b417 |
f41b417 to
ceb7d65
Compare
Contributor
Author
|
/ok to test ceb7d65 |
yanring
approved these changes
Dec 8, 2025
ceb7d65 to
dc7fe9e
Compare
Contributor
Author
|
/ok to test dc7fe9e |
ko3n1g
reviewed
Dec 8, 2025
ko3n1g
left a comment
Contributor
There was a problem hiding this comment.
Why are we deleting the golden values file?
Contributor
Author
Because it is in the lightweight mode and no need to compare with the golden value. Do you think we should keep it even so? |
Signed-off-by: oliver könig <okoenig@nvidia.com>
dc7fe9e to
9641a35
Compare
Contributor
Author
|
/ok to test 9641a35 |
ko3n1g
approved these changes
Dec 15, 2025
yuzhongw-nvidia
added a commit
to yuzhongw-nvidia/Megatron-LM
that referenced
this pull request
Jan 15, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
yuzhongw-nvidia
added a commit
to yuzhongw-nvidia/Megatron-LM
that referenced
this pull request
Jan 15, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
yuzhongw-nvidia
added a commit
to yuzhongw-nvidia/Megatron-LM
that referenced
this pull request
Jan 16, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
yuzhongw-nvidia
added a commit
to yuzhongw-nvidia/Megatron-LM
that referenced
this pull request
Jan 16, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
yuzhongw-nvidia
added a commit
to yuzhongw-nvidia/Megatron-LM
that referenced
this pull request
Jan 16, 2026
Minor refines Co-authored-by: Li Tao <lit@nvidia.com> fix CI get_transformer_block_with_experimental_attention_variant_spec Update test_mamba_moe_model.py Reopen qwen3next functional test in lightweight mode (NVIDIA#2493) Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.