Add per-module TE quant config.#2359
Merged
deepakn94 merged 6 commits intoNVIDIA:mainfrom Dec 5, 2025
Merged
Conversation
kwyss-nvidia
commented
Nov 22, 2025
Contributor
|
@kwyss-nvidia thanks for this PR? Will the executed quantization config also be printed to stdout? |
Contributor
Author
This is a smart idea. I just added a new commit with logging when the config is loaded. |
deepakn94
approved these changes
Dec 5, 2025
As an alternative to a myriad of flags to configure first and last layers (where number of layers is ambiguous with nesting of multilayer blocks as MTP), or particular blocks for mixed precision, a configuration file can provide TE recipes for quantization of linear and grouped linear layers.
Signed-off-by: Keith Wyss <kwyss@nvidia.com>
d79d675 to
5cd75ec
Compare
Contributor
|
/ok to test 5cd75ec |
ericharper
approved these changes
Dec 5, 2025
Signed-off-by: Keith Wyss <kwyss@nvidia.com>
auto-merge was automatically disabled
December 5, 2025 07:11
Head branch was pushed to by a user without write access
Contributor
|
/ok to test eac1def |
cspades
pushed a commit
to cspades/Megatron-LM
that referenced
this pull request
Jan 7, 2026
Signed-off-by: Keith Wyss <kwyss@nvidia.com>
6 tasks
ziang-and
pushed a commit
to zianglih/Megatron-LM
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Keith Wyss <kwyss@nvidia.com>
daiyaanarfeen
pushed a commit
to daiyaanarfeen/Megatron-LM
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Keith Wyss <kwyss@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative to a myriad of flags to configure first and last layers (where number of layers is ambiguous with nesting of multilayer blocks as MTP), or particular blocks for mixed precision, a configuration file can provide TE recipes for quantization of linear and grouped linear layers.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.