docs: nlopt wheel build for aarch64 (fixes #452)#589
Conversation
|
📝 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis change updates the Build from Source documentation to address ARM64/aarch64 systems where pre-built Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/getting_started/build_from_source/index.rst`:
- Around line 291-293: The documentation uses an undefined shell variable
`${PYTHON_VERSION}` in the uv command, which will break the build instructions;
update the block that contains "uv venv --python=${PYTHON_VERSION}
/tmp/nlopt-wheel-venv" to either (A) add a preceding instruction that defines
PYTHON_VERSION (for example export PYTHON_VERSION=3.11) or (B) replace the
`--python=${PYTHON_VERSION}` with a concrete version (e.g., --python=3.11) or
remove the `--python` flag to use the system default, and ensure the adjacent
commands ("VIRTUAL_ENV=..." and "/tmp/nlopt-wheel-venv/bin/python setup.py
bdist_wheel -d /tmp/nlopt-wheels/") remain consistent with the chosen approach.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cf6d5852-9af2-40b2-b6e6-1c573631f766
📒 Files selected for processing (1)
docs/source/getting_started/build_from_source/index.rst
|
/preview-docs |
|
✅ Preview deployed: https://NVIDIA.github.io/IsaacTeleop/preview/pr-589/ |
PyPI has no pre-built nlopt wheels for ARM64, causing retargeters installs to fail on aarch64 hosts (e.g. DGX Spark). Add a note to the Build from Source guide with step-by-step instructions to build an nlopt wheel from source (swig + cmake + DanielBok/nlopt-python 2.10.0) and use --find-links to supply it during isaacteleop install. Also quote all isaacteleop[extras] specs to prevent shell glob expansion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cf65284 to
28b9558
Compare
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
nloptwheels for ARM64, causingpip install 'isaacteleop[retargeters,...]'to fail on aarch64 hosts (e.g. NVIDIA DGX Spark) — reported in libnlopt-dev system dependency undocumented in Quick Start and Build from Source guides #452.nloptwheel from source usingswig+cmake+DanielBok/nlopt-pythonv2.10.0 (same approach used inexamples/teleop_ros2/Dockerfile).isaacteleop[extras]package specs in shell code blocks to prevent shell glob expansion.Test plan
nloptwheel builds anduv pip installsucceeds.sphinx) and check the note renders correctly in HTML.Closes #452
🤖 Generated with Claude Code
Summary by CodeRabbit
retargetersextra, including a workaround for buildingnloptfrom source due to missing pre-built wheels on PyPI.pipanduv pipto use local wheel caches.