Skip to content

Revert "[CudaIpc Tutorial] Minimal snippet example"#4248

Merged
naoyam merged 1 commit intomainfrom
revert-3912-cuda_ipc_tuto
Apr 14, 2025
Merged

Revert "[CudaIpc Tutorial] Minimal snippet example"#4248
naoyam merged 1 commit intomainfrom
revert-3912-cuda_ipc_tuto

Conversation

@wujingyue
Copy link
Collaborator

@wujingyue wujingyue commented Apr 14, 2025

Reverts #3912, which showed real errors before it was merged.

@wujingyue wujingyue requested a review from naoyam April 14, 2025 20:54
@github-actions
Copy link

github-actions bot commented Apr 14, 2025

Description

  • Reverted CUDA IPC tutorial minimal snippet example

  • Removed test_multidevice_ipc.cpp from CMakeLists.txt

Changes walkthrough 📝

Relevant files
Bug fix
test_multidevice_ipc.cpp
Removed CUDA IPC tests                                                                     

tests/cpp/test_multidevice_ipc.cpp

  • Removed entire file containing CUDA IPC tests
 +0/-200 
Configuration changes
CMakeLists.txt
Updated CMakeLists.txt                                                                     

CMakeLists.txt

  • Removed test_multidevice_ipc.cpp from test sources
 +0/-1     

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
⚡ Recommended focus areas for review

Test Removal

The PR removes a test file (test_multidevice_ipc.cpp) from the build configuration. Ensure that this removal is intentional and that the functionality it tested is covered elsewhere.

${NVFUSER_ROOT}/tests/cpp/test_multidevice_transformer.cpp

@wujingyue
Copy link
Collaborator Author

wujingyue commented Apr 14, 2025

!test

@naoyam naoyam merged commit 2bdb6d7 into main Apr 14, 2025
53 checks passed
@naoyam naoyam deleted the revert-3912-cuda_ipc_tuto branch April 14, 2025 23:01
@samnordmann samnordmann mentioned this pull request Apr 15, 2025
Merged
@samnordmann
Copy link
Collaborator

samnordmann commented Apr 15, 2025

Sorry about that. #4251 should fix it

wujingyue added a commit that referenced this pull request Apr 15, 2025
@wujingyue
Reapply "[CudaIpc Tutorial] Minimal snippet example" (#4248)
4bcd09a 
This reverts commit 2bdb6d7.
samnordmann added a commit that referenced this pull request Apr 16, 2025
@samnordmann
Fix Cuda Ipc Tuto (#4251)
91b1801 
Fix #3912 after it has been reverted
by #4248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naoyam naoyam naoyam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wujingyue @samnordmann @naoyam