Skip to content

Use box#87

Merged
jdonszelmann merged 6 commits into
mainfrom
use-box
Jun 8, 2023
Merged

Use box#87
jdonszelmann merged 6 commits into
mainfrom
use-box

Conversation

@jdonszelmann

Copy link
Copy Markdown
Collaborator

Closes #86

@NULLx76

NULLx76 commented Apr 21, 2023

Copy link
Copy Markdown
Owner

Somehow this change leads to UB according to MIRI, we should investigate

@jdonszelmann

Copy link
Copy Markdown
Collaborator Author

Fixed that, though it's a MIRI bug (stacked borrows isn't perfect). Throwing some more raw pointers against it made MIRI happy

@jdonszelmann

Copy link
Copy Markdown
Collaborator Author

cargo msrv fails in CI but passes locally

@NULLx76 NULLx76 force-pushed the use-box branch 2 times, most recently from 2566a32 to 5720d7b Compare June 6, 2023 06:56
It seems to break without error
@jdonszelmann jdonszelmann merged commit 52b2431 into main Jun 8, 2023
@jdonszelmann jdonszelmann deleted the use-box branch June 8, 2023 10:00
NULLx76 pushed a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AllocRingbuffer can use Box instead of Vec

2 participants