Implement nth and nth_back to provide a O(1) way of skipping through elements#142
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Owner
|
This PR looks straightforward and good, thanks for the work! @dzmitry-lahoda I've recently just been quite busy with university, no need to be inflammatory :) |
NULLx76
added a commit
that referenced
this pull request
Jul 11, 2025
Implement nth and nth_back to provide a O(1) way of skipping through elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By providing an override for the default implementation of
nth(andnth_back), which in turn is used byskip, there is a noticeable improvement in performance, as jumping through elements becomes a constant time operation.The implementation applies only to
RingBufferIteratorandRingBufferMutIterator, as they don't drop skipped elements.Benchmarks
With 16 elements in the ringbuffer, criterion shows a 47% performance improvement
While with 1024 elements, criterion shows a 97% performance improvement