Ensure key variables in the powerflow code have a minimum of zero#979
Merged
Conversation
…ich prevents swapping from not dispatching to charging
cpaulgilman
approved these changes
Jan 26, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Test case simulation finishes with outage loss reported in results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NatLabRockies/SAM#1324
The specific combination of factors in the test file was driving batt_to_load_ac negative, which lead to a positive batt_to_grid_ac, which caused an infinite loop between the powerflow code and the dispatch code. Fix this by preventing these variables from going negative.