SAM 658 restore pv priority manual dispatch#900
Merged
Conversation
… Move old powerflow code to attic
…atch for this variable
Removes charging constraints for min efficiency to handle grid outage cases. Removes ac losses (such as wiring) from batt to grid to make sure batt to grid matches AC power. Add DC DC efficency to batt power AC for full representation of convention where this number represents hypothetical grid charging when charging from PV. Update test code to better handle efficiencies
…forcing 5% efficiency. Use max efficiency for conversions in these cases
…tt. Solves issue with battery energy charged from system summary metrics being less than 100%
…iciency Update the powerflow convention. Using actual efficiency here would result in even higher round trip efficiencies. Also fix a possible infinity in the tests
Doing this on the DC side allows grid to batt to match inverter ac output
…es for a few tests
…ests to new conventions
…strating constrasting behavior
14 tasks
cpaulgilman
approved these changes
Oct 24, 2022
dguittet
approved these changes
Oct 25, 2022
…store_pv_priority_manual_dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves NatLabRockies/SAM#658 for manual dispatch.
Note - includes code from #899 to avoid merge conflicts. Might be best to do code review here after that one is merged.
Pairs with SAM pull request NatLabRockies/SAM#1205
To test:
Also works with generic system and fuel cell-commercial.