Skip to content

add system charging priority option to defaults. #1205

Merged
brtietz merged 7 commits into
developfrom
ssc_658_restore_pv_priority_manual_dispatch
Oct 25, 2022
Merged

add system charging priority option to defaults. #1205
brtietz merged 7 commits into
developfrom
ssc_658_restore_pv_priority_manual_dispatch

Conversation

@brtietz

@brtietz brtietz commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

Description

Solves SAM issue #658. Pairs with SSC PR NatLabRockies/ssc#900

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added enhancement battery requires help revision Requires a Help revision before releasing public version labels Oct 23, 2022
@brtietz brtietz added this to the SAM Fall 2022 Release milestone Oct 23, 2022

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I will use your comments here and for SAM 658 to update Help.

@brtietz brtietz merged commit 2d8e2b7 into develop Oct 25, 2022
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Oct 31, 2022
@mjprilliman

Copy link
Copy Markdown
Collaborator

Looking at callback errors from this I was finding in #1255. I'm assuming we don't want to have these options show up for standalone battery?

@brtietz brtietz deleted the ssc_658_restore_pv_priority_manual_dispatch branch November 18, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants