Improve labeling of loss percentage inputs for AC/DC#889
Merged
Conversation
12 tasks
brtietz
reviewed
Oct 11, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
This is definitely an improvement, but I'm not sure about the transformer_load_loss and the transmission_loss getting the same label. They are applied sequentially (transformer before transmission).
| {SSC_INPUT, SSC_NUMBER, "acwiring_loss", "AC wiring loss", "%", "", "Losses", "*", "MIN=0,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "transmission_loss", "Transmission loss", "%", "", "Losses", "*", "MIN=0,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "acwiring_loss", "AC wiring loss", "%", "percent of inverter AC output", "Losses", "*", "MIN=0,MAX=100", "" }, | ||
| {SSC_INPUT, SSC_NUMBER, "transmission_loss", "Transmission loss", "%", "percent of AC output", "Losses", "*", "MIN=0,MAX=100", "" }, |
Collaborator
There was a problem hiding this comment.
Is it worth indicating that the transmission loss is applied after transformer losses?
Collaborator
Author
There was a problem hiding this comment.
Yes, thanks for that suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with NatLabRockies/SAM#1183