Improve AC/DC unit descriptions#1183
Merged
Merged
Conversation
Use kWac, kWdc, kWhac, kWhdc, etc convention instead of DC kW, kW DC, etc.
## October 11, 2022 Battery results: Battery lifetime AC/DC units Operating costs: Fix AC/DC units, revise escalation. PV losses: Explain percentages for transformer losses, and list output variable names. ## September 23, 2022 Grid outage explain battery SOC may go up to 100%: https://sam.nrel.gov/forum/forum-general/3977-battery-soc-when-constrained.html ## September 9, 2022 Remove inputs browser link to parametrics youtube video. ## September 1, 2022 Merchant plant: Note that revenue is zero if cleared capacity is zero for all time steps. ## July 29, 2022 Revenue: Add link to CPUC procurement website for TOD factor library references Replace "REopt Lite" with "REopt" per #1090 ## July 20, 2022 Inverter, Weighted Efficiency, update link to European weighted efficiency paper. ## July 13, 2022 Generic CSP solar field area estimate in UI different from simulation value: https://sam.nrel.gov/forum/forum-general/3947 PV system design typo in tilt description suggestion to use parametrics: #1084 ## June 8, 2022 Fix dead link in Module NOCT temp model description to https://www.energy.ca.gov/programs-and-topics/programs/new-solar-homes-partnership-program-nshp Self shading diffuse irradiance available for thin film and standard self-shading options since SAM 2020.2.29: https://sam.nrel.gov/forum/forum-general/3087
Also includes unrelated changes to inputs for ETES model
Collaborator
|
Nice work! I found two or three that slipped through: Battery voltage hasn't been updated to the new lowercase "dc" convention: Capacity values are labelled for O&M but not capacity payments: Fuel cell dispatch (this one feels pedantic): There are a few other instances of kWh in the revenue and utility rates pages that feel like are obviously ac, and I'm happy to leave as is. |
brtietz
requested changes
Oct 20, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for handling my requested changes. It looks like the GitHub Actions failures are legit, happy to help talk about a fix.
| "ui_copy_batt_discharge_percent_6": 25.0, | ||
| "ui_net_capital_cost": 46901.9, | ||
| "ui_pv_capacity": 4.0, | ||
| "ui_plant_capacity": 3.335046e-317, |
Collaborator
There was a problem hiding this comment.
It looks like this is potentially the cause of the GH Actions failure:
Maybe reverting the value to the original value will fix the issue? That or a form is out of date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Goes with NatLabRockies/ssc#889
Description
Fixes #1126
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.