add ts_hour to ac wiring loss line#879
Merged
Merged
Conversation
Collaborator
Author
|
Push build on ubuntu failed due to error connecting to cmake. We can either re-run the tests or trust the results of the mac push and pull request builds. |
Collaborator
All tests seem to be passing now! |
sjanzou
approved these changes
Sep 30, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Much better for subhourly models! AC wiring loss no longer multiplies with ts_hour!
All tests now passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
Unchecking the "save all output variables over lifetime" option is recommended if testing with a one minute weather file.
Fixes NatLabRockies/SAM#1082