add function that was enforcing dispatch soc limits for lithium ion batteries#833
Merged
Merged
Conversation
cpaulgilman
approved these changes
Jun 2, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
This improves the battery roundtrip efficiency reported by the "default" Generic Battery / Commercial configuration from 100% to 91.53%.
Note that there is not a configuration in the defaults for lead acid batteries, so I tested this by creating a default case and changing the battery type without changing any other parameters based on the approach reported by a user here: https://sam.nrel.gov/forum/forum-general/3890.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #832 by ensuring the check_soc function is applied to both battery types.