Describe the bug
Due to #569, the voltage table sometimes ends up outside of the state of charge bounds specified on the dispatch page. When this happens, the following timestamp gets an increase in charge to the minimum SOC without properly accounting for the battery charging in the powerflow equations. This results in free energy and a round trip efficiency >= 100%.
To Reproduce
Steps to reproduce the behavior:
- Create a generic-battery commercial case
- Change the battery chemistry to lead acid - flooded
- Run the simulation
- Check the annual energy charged vs discharged
- See that the annual energy discharged is >= charged
Expected behavior
With the defaults, the maximum round trip efficiency should be 92.16% - this would be a 100% DC-DC efficiency. While this is also unrealistically high, we plan to address it in #831
Fixing #569 would also assist with this issue, but I view 569 as a problem with the voltage code and this as a problem with the capacity code.
Desktop (please complete the following information):
- Version 2021.12.02 r1 (and possibly earlier)
Describe the bug
Due to #569, the voltage table sometimes ends up outside of the state of charge bounds specified on the dispatch page. When this happens, the following timestamp gets an increase in charge to the minimum SOC without properly accounting for the battery charging in the powerflow equations. This results in free energy and a round trip efficiency >= 100%.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
With the defaults, the maximum round trip efficiency should be 92.16% - this would be a 100% DC-DC efficiency. While this is also unrealistically high, we plan to address it in #831
Fixing #569 would also assist with this issue, but I view 569 as a problem with the voltage code and this as a problem with the capacity code.
Desktop (please complete the following information):