add soc limits to pv smoothing#816
Merged
Merged
Conversation
sjanzou
approved these changes
May 17, 2022
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
The soc limit is indeed recording another violation, the output power continues to discharge on next step for both cases. I think this is consistent with the original code and the smoothing paper:
with full soc - no additional violation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #815 see that issue for test file.
Note that there is some weird behavior where the PV smoothing output power is negative at night. I view that as a tuning or sizing issue, and out of scope for this PR.