Skip to content

783 sequential wiring and transmission losses#790

Merged
brtietz merged 8 commits into
patchfrom
783_sequential_wiring_and_transmission_losses
Apr 27, 2022
Merged

783 sequential wiring and transmission losses#790
brtietz merged 8 commits into
patchfrom
783_sequential_wiring_and_transmission_losses

Conversation

@brtietz

@brtietz brtietz commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

Apply the wiring loss and then the transmission loss, so that the numbers can't be greater than 100%. Update the loss calculations so this appropriately shows up in the loss diagram. Transmission losses were added in SAM PR 1000

I'm happy to add a unit test for this, but wanted to confirm the loss behavior with you prior to writing it.

@brtietz brtietz added bug pv photovoltaic, pvsam, pvwatts labels Apr 4, 2022
@brtietz brtietz added this to the 2021.12.02 Patch 2 milestone Apr 4, 2022
@brtietz brtietz requested a review from janinefreeman April 4, 2022 14:42
@janinefreeman

Copy link
Copy Markdown
Collaborator

A little testing looks good, one thing this does bring up is that the warning about the inverter being oversized seems to get triggered downstream of the actual inverter calculation (after AC and transmission losses), which is probably not the intent of that warning. Possibly a separate issue? Thoughts?

@brtietz

brtietz commented Apr 6, 2022

Copy link
Copy Markdown
Collaborator Author

A little testing looks good, one thing this does bring up is that the warning about the inverter being oversized seems to get triggered downstream of the actual inverter calculation (after AC and transmission losses), which is probably not the intent of that warning. Possibly a separate issue? Thoughts?

I'm willing to lump that in here - the tricky part is that there isn't currently a timeseries output that has the data needed to fix that issue. Would adding something like "inverter output AC gross" as a timeseries output be helpful? Preferences on naming?

@brtietz brtietz merged commit b130bde into patch Apr 27, 2022
brtietz pushed a commit that referenced this pull request Apr 27, 2022
783 sequential wiring and transmission losses (#790) to develop
@brtietz brtietz deleted the 783_sequential_wiring_and_transmission_losses branch April 29, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes bug pv photovoltaic, pvsam, pvwatts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV Wiring and Transmission Losses are both subtracted from the same number

3 participants