Skip to content

Confirm net means net#756

Merged
brtietz merged 2 commits into
om_var_labelsfrom
confirm_net_means_net
Feb 11, 2022
Merged

Confirm net means net#756
brtietz merged 2 commits into
om_var_labelsfrom
confirm_net_means_net

Conversation

@brtietz

@brtietz brtietz commented Feb 10, 2022

Copy link
Copy Markdown
Collaborator

Use consistent values for cf_energy_net throughout the code - this should always just be "sum of gen." The previous code used "positive numbers in gen" for about half the time and then switched it after the PPA calculation loop. Fixing this required updating some values of cf_energy_net to cf_energy_sales. This calculation change and the associated labels changes should address Steve's comments in NatLabRockies/SAM#927

The goal of this PR is that no numbers with units of $ should change at the end of the calculation. Changes in values with units of kWh for behind the meter systems are expected.

Note that there are some output names that need to be changed that aren't here. That seems out of scope for this PR, so I made a follow up issue: #755

Brian Mirletz added 2 commits February 10, 2022 14:17
ensure sales and net always mean gross and net in the cash flow model…
d6f4ffb 
…s, respectively. This commit should create no changes in variables with units of $, but some variables with units of energy are now more consistent
change the labels for behind the meter configurations
d15d593
@brtietz brtietz added this to the 2021.12.02 Patch 1 milestone Feb 10, 2022
@brtietz

brtietz commented Feb 10, 2022

Copy link
Copy Markdown
Collaborator Author

Test failures are segmentation faults on mac only and should be resolved once #749 is merged

@cpaulgilman

cpaulgilman commented Feb 11, 2022

Copy link
Copy Markdown
Collaborator

Here's an LK script I'm using to investigate:

vars = ['cf_energy_curtailed','cf_energy_purchases','cf_energy_without_battery','cf_energy_net','cf_energy_sales','batt_annual_discharge_energy','fuelcell_annual_energy_discharged','annual_energy'];

for ( i=0; i<#vars; i++ )
{
	outln(vars[i] + ' = ' + get(vars[i]) );
	outln( varinfo(vars[i]));
	outln();
}

cpaulgilman
cpaulgilman approved these changes Feb 11, 2022
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the energy variables I need for cash flow fixes in #927.

sjanzou
sjanzou approved these changes Feb 11, 2022
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the failing mac test was definitely fixed in pull request #749, which was merged into patch and develop.

@brtietz brtietz merged commit 464f9f6 into om_var_labels Feb 11, 2022
@brtietz brtietz deleted the confirm_net_means_net branch April 29, 2022 16:05
@brtietz brtietz mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjanzou sjanzou sjanzou approved these changes

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

No one assigned

Labels

added to release notes financial

Projects

None yet

Milestone

2021.12.02 Patch 1

Development

Successfully merging this pull request may close these issues.

3 participants

@brtietz @cpaulgilman @sjanzou