Update pvsamv1, pvwattsv8 var tables#927
Merged
Merged
Conversation
cpaulgilman
approved these changes
Nov 10, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Perhaps set the "META" attribute for all of the [xxx]_is_bifacial variables to 0=monofacial,1=bifacial so they are consistent with cec_is_bifacial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix loss input variables for pvsamv1 subarrays 2 through 4,
-Add integer, min, and max constraints for module_model parameters where appropriate
-align gcr, use_wf_albedo defaults in var table for pvwattsv8 to pvsamv1
-update pvwattsv8 test results affected by change to use weather file albedo