Fix ssc 856 xfmr losses#728
Merged
Merged
Conversation
… them for dc connected batteries
cpaulgilman
approved these changes
Jan 21, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NatLabRockies/SAM#856
The DC connected batteries need an estimate of loss percent for grid outages, but since some of the transformer load losses use *= the calculation was being applied twice. Reset the variables after the DC loss estimation to fix the issue.
Test by specifying a transformer load loss in a default case. An AC connected battery and DC connected battery should have similar transformer loss %s after running.