Added divide by zero check for BTM battery grid charging cost#679
Merged
Conversation
calculations in LCOS function
brtietz
approved these changes
Nov 30, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! I agree that it makes sense that the value of true up payments should be zero if there is no net energy drawn from the grid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Avoid error in LCOS BTM calculations by checking for 0 monthly grid charge before performing parasitic cost calculations
-Fixes NatLabRockies/SAM#801