Batt btm to grid and manual clip#653
Merged
Merged
Conversation
added 11 commits
November 5, 2021 09:55
…o_grid_and_manual_clip
…_grid_and_manual_clip
…o_grid_and_manual_clip
Collaborator
Author
|
Failure matches version of develop used to create this branch. Develop was fixed here: https://github.com/NREL/SAM/runs/4182767103. I can merge in develop and re-run if desired, but refraining for now to save Travis credits. |
mjprilliman
approved these changes
Nov 12, 2021
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
I didn't notice any issues but I'm not as familiar with this code
| ssc_number_t peakKwCharge = *std::min_element(batt_power_data.begin(), batt_power_data.end()); | ||
|
|
||
| EXPECT_NEAR(peakKwDischarge, 1.98, 0.1); | ||
| EXPECT_NEAR(peakKwDischarge, 2.16, 0.1); |
Collaborator
There was a problem hiding this comment.
I'm sure I missed it but is this change due to the DischargetoGrid defaulting to true?
Collaborator
Author
There was a problem hiding this comment.
Yes - since the discharge is no longer limited to load, the peak discharge can increase.
added 3 commits
November 12, 2021 09:03
…o_grid_and_manual_clip
…o_grid_and_manual_clip
…o_grid_and_manual_clip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with SAM PR NatLabRockies/SAM#754
Update charging and discharging constraints to allow:
PVWatts-Battery defaults grid discharging to true.
Peak shaving, grid power targets, and price signals dispatch will need updates to take advantage of grid discharge capabilities. This can be done in a future PR for a patch.
Solves SAM issues NatLabRockies/SAM#338 and NatLabRockies/SAM#407