Add simulation timestep variable for stand alone battery#1227
Merged
Conversation
mjprilliman
approved these changes
Oct 24, 2024
cpaulgilman
approved these changes
Oct 25, 2024
cpaulgilman
requested changes
Oct 25, 2024
Collaborator
There was a problem hiding this comment.
@brtietz Please wait until I update Help context ID in startup to merge this.
Collaborator
|
@brtietz Should there be an error check for BTM standalone battery when the load time step or input grid power target time step does not match the simulation time step? |
Collaborator
|
Help revisions: Battery Time Step
FOM Battery Dispatch
BTM Battery Dispatch
|
cpaulgilman
approved these changes
Oct 25, 2024
Collaborator
Author
This is handled in ssc, which matches the behavior of the PV and generic system coupled configurations. See lines 1329 and 1363 of cmod_battery.cpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new variable timestep_minutes to control the length of the zero lifetime array within the stand alone battery. Subsequent variable checks are still enforced against this new variable.
Pairs with SAM PR NatLabRockies/SAM#1887
Closes #994