Variables and forms for setting standalone battery timestep#1887
Conversation
|
It looks like the 'Battery Standalone Timestep.json' UI form didn't make it into the commit here. |
Thanks for catching, just pushed it! |
mjprilliman
left a comment
There was a problem hiding this comment.
This error message could use some additional text as there is no weather file (BTM standalone battery mismatch between timestep and load timestep).
On the UI form, fit the group box to the contents, give a larger buffer between the text and the group box for different fonts on different platforms, and reduce the width of the dropdown some.
On version upgrade, maybe set timestep_minutes and timestep_minutes_ui to the corresponding value from curtailment, revenue, or load length from the old case?
mjprilliman
left a comment
There was a problem hiding this comment.
Looks good, just a couple nitpicks and some things to check when going through the release checklist.
| i++; | ||
| } | ||
|
|
||
| value("timestep_minutes", timestep_mins); |
There was a problem hiding this comment.
This reads a little confusing because they have the same label. Maybe change the actual minutes variable (not the UI one)?
| @@ -0,0 +1,184 @@ | |||
| { | |||
There was a problem hiding this comment.
Just a note to check this on Mac and Linux to make sure there's no overlap between the line and text on the left hand side during pre-release checklist.
There was a problem hiding this comment.
I redid this a bit, so it should work across platforms and line up with the other battery forms:
|
@brtietz, @mjprilliman Any objections to moving this form to the Battery Cell and System page so that it appears under the "Chemistry" group? Right now when you create a new Standalone Battery case, all you see is the simulation time step input with the Battery item in the navigation collapses, which might cause some folks to panic. |
No objections to moving it. I trust your intuition on user expectations & panic levels. |
This makes Battery Cell and System the page that loads for standalone battery configurations instead of the Battery Time Step page
I moved it below Battery Cell and System as a compromise -- simpler implementation than putting it on Battery Cell and System page and avoids the potential panic.
|
Add new page for stand alone battery timestep, and add it to the "battery" group before the cell and system info.
List numbers don't seem to translate directly into ssc, so add some lk to deal with this.
Mismatches with load, revenue, and curtailment lengths are enforced within ssc as appropriate, the other battery models don't have red text or pop up warnings for these, so I haven't added them here.
Does this require changes to the version upgrade script, or is that a separate effort?
Goes with NatLabRockies/ssc#1227