Use calculated DNI for Allen method when there is no DNI in weather file#1126
Conversation
clipping correction
cpaulgilman
left a comment
There was a problem hiding this comment.
The simulation runs without crashing now, but the subhourly clipping loss seems very high. This is for the default Detailed PV / No Financial model with the weather file attached below:
Weather file used for testing:
Which Irradiance data option did you use for these results? I'm having trouble replicating results. |
|
I'm not seeing those results now. Perhaps I was in the wrong version of SAM. Please ignore my previous comment. However, I am getting an exception in cmod_pvsamv1.cpp when I run a simulation with the default DNI+DHI option with the weather file that has no DNI data. The release version of SAM 2023.12.17 correctly generates an SSC error message, so I think this may have been introduced in this branch: |
Paul, I caught that error too, apologies for not updating. I am working on a fix and will push shortly. |
|
That will fix NatLabRockies/SAM#1685 |
code failing due to no dni provided)
cpaulgilman
left a comment
There was a problem hiding this comment.
Looks good now. I tested weather file with no DNI with and without subhourly clipping. I'll work on the UI change for NatLabRockies/SAM#1666 next.




-Fixes #1123
-Fixes NatLabRockies/SAM#1685
-Check for nan for weather file DNI, use calculated DNI as alternative