Skip to content

Fix #2044 - Remove Oniguruma Lookbehind with unicode matcher #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdahlhausen merged 1 commit into from
Nov 17, 2025
Merged

Fix #2044 - Remove Oniguruma Lookbehind with unicode matcher #2045

mdahlhausen merged 1 commit into from
Nov 17, 2025
+4 −2

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Nov 14, 2025

Pull request overview

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec mentioned this pull request Nov 14, 2025
Merged
19 tasks
jmarrec added a commit to NREL/OpenStudio that referenced this pull request Nov 17, 2025
@jmarrec
Try with openstudio-standards patched to remove regex unicode lookbehind
3a86687 
* NREL/openstudio-gems#121
* NREL/openstudio-standards#2045
@jmarrec jmarrec requested a review from mdahlhausen November 17, 2025 10:21
jmarrec
jmarrec commented Nov 17, 2025
View reviewed changes
lib/openstudio-standards/btap/costing/daylighting_sensor_control_costing.rb
Comment on lines +8 to +9
# insert a space between NECB and 2011/2015/2017
standards_template = standards_template.gsub(/NECB(\d)/, 'NECB \1')
Copy link
Collaborator Author

@jmarrec jmarrec Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm playing it safe here, not assuming it's "NECB2011" without a space to begin with. But anyways, gets the job done and the now the OS SDK CLI doesn't choke on it. cf NREL/OpenStudio#5513 (comment)

@mdahlhausen mdahlhausen merged commit a7a84c4 into master Nov 17, 2025
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the 2044_remove_unicode_regex_lookbehind branch November 17, 2025 17:15
@jmarrec jmarrec mentioned this pull request Nov 20, 2025
Merged
anchapin pushed a commit to NREL/OpenStudio that referenced this pull request Nov 30, 2025
@jmarrec
Try with openstudio-standards patched to remove regex unicode lookbehind
4500c5b 
* NREL/openstudio-gems#121
* NREL/openstudio-standards#2045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdahlhausen mdahlhausen mdahlhausen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Oniguruma Lookbehind with unicode matcher and similar constructs

3 participants

@jmarrec @mdahlhausen