Update which applies the local costing .csv files, fixing the costing issue #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting, changed how the database is loaded.
ckirney
added a commit
that referenced
this pull request
Aug 11, 2025
* Change the error log level to warn to avoid testing failures. * Address comments. * force to perform sizing run for bldg_11 and bldg_17 * address comments * Address test (some) failures #2. * use OS defined options * Update DOE ref chiller efficiencies * add version check for VRF cooling COP `setRatedCoolingCOP` was deprecated in OS v2.9.0 and replaced with `setGrossRatedCoolingCOP` * Update hvac_systems.rb * Fix typo. * Missing default assignement. * Update test_apply_hvac_efficiency_standard.rb * shorten exterior_lighting_zone_number replace 'exterior_lighting_zone_number' with 'lighting_zone' * merge data schema and edit tests The 90.1-2004 and later vintages of 90.1 now have a different data schema from other standard templates. Update the code to account for the different data schema. Update to the tests to account for object renaming. * Revert name. * Re-export database. * add search for legacy energy codes (2016 or earlier) * update the function call by adding a surface to avoid gc construction to be created as a regular construction * Use W/ft2 by default for building facade. * reactiviate test, it passed locally. * Handle large motors. * Handle fractional HP motors. * Adjust lookups. * Add schema and update user data processing. * Fix broken lookup. * adjust format to trigger CI * update the test assertion to use actual false type instead of string as the algorithm has updated. * update the parameter in the test * duplicate construction for repeated types. * modify format to trigger CI again * make duplicate constructions. * Remove excessive function * Updates * Bunch of formatting but the critical changes are: 1. adding has space conditioning category in the apply standard constructions 2. Realign the boundary condition if else. 3. Readjust the logic to recreate existing construction per boundary_con, surf_type, const_type for each unique combination. 4. Fix a bug in bldg_18.osm * correct the incorrect user data electric equipment * 1. fix the issue in the testing for pe PRM 2. use if instead of unless to re-organize the logic that bypasses surfaces. 3. include more general construction types in the deep copy function. * add refrigerated case method * add create_walkin method * correct argument description * Update test_create_walkin.rb * add create_compressor method * fix airboundary construction deep copy issue * allow climate zone 0 in nist infiltration use coefficients for climate zone 1 if the model climate zone is 0. * Update regression and performance test results. * add exception check in the construction_set_surface_slab_f_factor function * add typical supermarket space type ratios * add deer Gro test * Address review comments and fix headers. * template create typical refrigeration untested * Address surprise test failures. * Update Prototype.refrigeration.rb * add tests for create refrigeration system * add create typical refrigeration tests * undo changes to size category * Update regression/performance tests. * Address final (?) test failure. * add support for self-contained units - add create_compressor_rack - use indoor compressor rack (to model a self-contained unit) for small buildings. Require thermal zones to do so. - replace model_typical_display_case_zone with refrigeration_case_zone - replace model_typical_walkin_zone with refrigeration_walkin_zone * remove latent case credit method already included in refrigeration case data * add ref equip list method example method to get refrigeration equipment list from building properties * adjust Gro space type ratios remove Gro RefWalkInCool and RefWalkInFreeze space types and place walkins in RefFoodPrep instead. ensure space type ratios sum to 1.0. * add typical refrigeration equipment list add list of typical refrigeration equipment by building type and space type. Typical case lengths and walkin area is linked to a reference size of the space type, and then model cases and walkins are scaled accordingly. Walkins have a minimum size of 80 ft2 and maximum size of 480 ft2. * Deactivating or deleting lines or files that do not belong in master right now. * Include updated test results reflecting changings from using OS 3.9.0. * Include updated test results reflecting changings from using OS 3.9.0. * update cases data - copy some existing cases to fill out all case types for all templates - change names to avoid commas in name for E+ * Update typical_refrigerated_cases.csv * remove all refrigeration objects in create typical * data_update (crac_only) e89e6c4 * Modify lookups. * deprecate model_add_typical_refrigeration replace model_add_typical_refrigeration with create_typical_refrigeration * remove comstock and deer refrigeration data * Updating regression tests to reflect changes in OS 3.9.0. Updating autozone.rb to reflect changes to space_type_apply_internal_load_schedules arguments. * Updating regression tests to reflect changes in OS 3.9.0. Updating autozone.rb to reflect changes to space_type_apply_internal_load_schedules arguments. * update typical refrigeration logic - fix typo in typical walkin csv - don't add a refrigeration system if there are no cases or walkins - add more tests * revert changes revert some breaking changes and file additions * temp disable necb tests * Add reference curves and fix some lookups. * update doe regressions to OS v3.9 Disable large offices until the update to OS v3.10, which will include the E+ bug fix in E+ PR #10859 for cooling tower indexing * Update compare_models_helper.rb ERV table independent variable name lists are not deterministic * disable large offices tests revert once tests use OS v3.10, which will include the E+ bug fix in E+ PR #10859 for cooling tower indexing * Address test failures. * update typical refrigeration assumptions base on case and walkin amounts from an average of two case study buildings * rubocop fixes * add todo comment * Update space_type_ratios.rb * disable large office tests * Update necb_helper.rb Parse json files and compare directly rather than a text comparison. * make separate system size limit an option argument * use clamp instead of .min.max * Revert "Update space_type_ratios.rb" This reverts commit 69a7e77. * Reapply "Update space_type_ratios.rb" This reverts commit c0aa8c7. * require thermal zone for refrigeration equipment * replace string lookup with typical refrigeration .csvs * remove excess compares in necb expected results * set case zone in create refrigeration system test * 8.0.rc1 * refrigeration data fixes - fix missing case - fix case defrost curve name - fix typo in compressor curve data * add 'Gro' to infiltration lookup * add exterior lighting supermarket test * Merge branch 'master' into LandanT/Issue129_CA_WAREH_OFFICE_Change * add ext lighting properties method * Update space_type_ratios.rb * Update Prototype.CentralAirSourceHeatPump.rb * Update .yardopts - add exterior lighting and refrigeration modules to documentation * Update simulation.rb Don't run simulation for sizing periods during sizing run. It will still run zone, system, and plant sizing, but not simulate the design days. * Update version.rb * set sizing flow fraction during heating to 1 Due to changes in EnergyPlus (NREL/EnergyPlus#10763), some models fail during system sizing for reheat coils, particularly in cold climate zones (ASHRAE CZ 8). This sets the flow fraction to 1.0 instead of relying on the lower default in OpenStudio. * update regression models only minor change to set 'Heating Maximum Air Flow Fraction' in the 'SizingZone' object rather than using default. * 0.8.0.rc3 * fix log message variables * Update version.rb * change case schedule name * add more DEER bldg types to NIST infiltration * change exhaust fan log msg to debug * Update Lighting, Occupancy, and Equipment Schedules for 90.1 Models * Update lighting, occupancy, and equipment schedules for DEER Grocery Models * disable self-contained units Disable self-contained refrigeration units until we have efficiency data and cases and walkins can connect to those systems and simulate correctly. * Attempt to fix NECB test failures. * Add a failing test for#1946 This is the official E+ Kona file: https://energyplus.net/weather-location/north_and_central_america_wmo_region_4/USA/HI/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3 https://energyplus-weather.s3.amazonaws.com/north_and_central_america_wmo_region_4/USA/HI/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.zip * `iconv -f WINDOWS-1252 -t UTF-8 USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.stat -o new && mv new USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.stat` * Fix #1946 - Don't throw when parsing a stat file that has no discernible dry period * Add a test for #1948 using https://climate.onebuilding.org/WMO_Region_4_North_and_Central_America/USA_United_States_of_America/CO_Colorado/USA_CO_Denver.Intl.AP.725650_TMYx.2009-2023.zip * Fix #1948 - allow parsing TMYx stat files * add default design conditions for ERV properties resolve multiple data return message in the erv properties lookup only impacts 90.1-2013 and 90.1-2016 * switch data from .csv to .json - .csv files don't get built in the embedded gem in ruby in OpenStudio. Convert the data to .jsons and use the .jsons instead. - adjust logging message location for infiltration * Add .gitignore for temp measure testing add a .gitignore for a directory to test measure for openstudio-standards integration testing * full case statement for design conditions * error message if no climate zone * Update version.rb * use File.dirname(__FILE__) instead of __dir__ * rubocop fixes * fix yard doc errors * Change StatFIle design size info to warning * use save navigation operator in json converter use safe navigation operator to get null instead of 0 for fields to avoid divide by zero or inappropriate zero values * revert changes to 90.1-2016 ervs * parking data safe navigation * use File.dirname(__FILE__) instead of __dir__ * update version * use helper function file? to check if file exists in the cli embeeded file system * formatting csv fiels as UTF-8 without the BOM marker * Add parallel option in the measure to parallelize the baseline sizing run based on orientation. disable parallel in CI testing * Attempt to fix NECB test failures, bis. * Address add HVAC systems and regression test failures. * Exclude PTHPs from specific search criteria and fix typo. * Missing objects. * Rubocop * Update Standards.CoilCoolingDXMultiSpeed.rb update data properties comment * add run design day sim option to model_run_sizing_run Add sizing_run_simulation argument to model_run_sizing_run defaulted to false. For NECB tests, set to true for the few NECB tests using CGSHP that require full design day runs for sizing. * Update create_case.rb * change default design day sim to true Setting to false causes some issues with SingleSpeed DX coils in the set COP and capacity lookups; possibly related to how the get capacity methods are implemented. * Updating NECB regression and unit test expected results. * Inculding references to space module * Reverting btap_cli test run_options.yml files. * make supermarket schedules constant Set constant values for heating and cooling schedules. The original values were from end use data, which was an average. It appears some stores had setbacks and most didn't, and the results is slight (1C) setbacks overnight. That causes issues in parametric schedules and sawtooth schedules. This commit changes the values to a constant average temperature. * simplify schedule * Resize any DX heating coils with a very small capacity to a capacity of 1 kW if sizing run foils and rerun sizing run. * Logging resizing of DX heating coil capacity * Update necb_2011.rb * Create separate sizing run method that handles DX coil failures. Use in NECB2011 and BTAPPRE1980 classes. * Adding try_sizing_run method to sizing run 2. Inculding sizing run subdirectory as try_sizing_run method argument. * Changing autozone.rb so methods use try_sizing_run method. Updating try_sizing_run method to include additional argument from master. * add defrost and dripdown schedule variation add defrost and dripdown schedule variation to refrigerated cases and walkins. Iterate the start hour over the cases and walkins added to the model. Add fields for defrosts per day and duration to the typical cases and walkins data. Assumptions for these values are placeholder values for now, based on prior values and a quick internet search. The purpose for adding variation is so that all the schedules aren't synced and cause a spiky profile in demand. * including space_multiplier_map in model_create_thermal_zones in apply_auto_zoning method. * Add modal validation back to try_sizing_run method. * Removing test line * Inculde HighriseApartment model that uses TZ multipliers instead of modelling each floor explicitly. * Update regression test files. * Update btap_datapoint.rb to enable missing require statements * Intentionally breaking GSHP costing to test AWS. * update defrost and dripdown schedules - for cases, default to one 45 minute defrost cycle per day followed by a 5 minute dripdown - for walkins, default to two 45 minute defrost cycles per day followed by a 5 minute dripdown - add logic to avoid adding defrost and dripdown schedules if offcycle - add logic to handle dripdowns exceeding the hour after a defrost - update cases and walkins defrost and dripdown values from the ORNL database * Removing intentional error * Updating regression test results even though all tests had passed * Update costing file paths * Making costing file path absolute * Update which applies the local costing .csv files, fixing the costing issue (#1981) * Removed costing_database.json, changed update_costing to validate_costing, changed how the database is loaded. * Changed all occurences of .exists? to .exist? --------- Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com> --------- Co-authored-by: Xu, Weili <weili.xu@pnnl.gov> Co-authored-by: Lerond <jeremy.lerond@pnnl.gov> Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com> Co-authored-by: Jeremy L. <5149279+lymereJ@users.noreply.github.com> Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov> Co-authored-by: Taylor <landan.taylor@nrel.gov> Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com> Co-authored-by: lymereJ <jeremy.lerond@gmail.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com> Co-authored-by: Eric Ringold <ericringold@gmail.com> Co-authored-by: tijcolem <tjc.coleman@gmail.com> Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com>
ckirney
added a commit
that referenced
this pull request
Aug 12, 2025
* Including reference to costing csv files (#1983) * Change the error log level to warn to avoid testing failures. * Address comments. * force to perform sizing run for bldg_11 and bldg_17 * address comments * Address test (some) failures #2. * use OS defined options * Update DOE ref chiller efficiencies * add version check for VRF cooling COP `setRatedCoolingCOP` was deprecated in OS v2.9.0 and replaced with `setGrossRatedCoolingCOP` * Update hvac_systems.rb * Fix typo. * Missing default assignement. * Update test_apply_hvac_efficiency_standard.rb * shorten exterior_lighting_zone_number replace 'exterior_lighting_zone_number' with 'lighting_zone' * merge data schema and edit tests The 90.1-2004 and later vintages of 90.1 now have a different data schema from other standard templates. Update the code to account for the different data schema. Update to the tests to account for object renaming. * Revert name. * Re-export database. * add search for legacy energy codes (2016 or earlier) * update the function call by adding a surface to avoid gc construction to be created as a regular construction * Use W/ft2 by default for building facade. * reactiviate test, it passed locally. * Handle large motors. * Handle fractional HP motors. * Adjust lookups. * Add schema and update user data processing. * Fix broken lookup. * adjust format to trigger CI * update the test assertion to use actual false type instead of string as the algorithm has updated. * update the parameter in the test * duplicate construction for repeated types. * modify format to trigger CI again * make duplicate constructions. * Remove excessive function * Updates * Bunch of formatting but the critical changes are: 1. adding has space conditioning category in the apply standard constructions 2. Realign the boundary condition if else. 3. Readjust the logic to recreate existing construction per boundary_con, surf_type, const_type for each unique combination. 4. Fix a bug in bldg_18.osm * correct the incorrect user data electric equipment * 1. fix the issue in the testing for pe PRM 2. use if instead of unless to re-organize the logic that bypasses surfaces. 3. include more general construction types in the deep copy function. * add refrigerated case method * add create_walkin method * correct argument description * Update test_create_walkin.rb * add create_compressor method * fix airboundary construction deep copy issue * allow climate zone 0 in nist infiltration use coefficients for climate zone 1 if the model climate zone is 0. * Update regression and performance test results. * add exception check in the construction_set_surface_slab_f_factor function * add typical supermarket space type ratios * add deer Gro test * Address review comments and fix headers. * template create typical refrigeration untested * Address surprise test failures. * Update Prototype.refrigeration.rb * add tests for create refrigeration system * add create typical refrigeration tests * undo changes to size category * Update regression/performance tests. * Address final (?) test failure. * add support for self-contained units - add create_compressor_rack - use indoor compressor rack (to model a self-contained unit) for small buildings. Require thermal zones to do so. - replace model_typical_display_case_zone with refrigeration_case_zone - replace model_typical_walkin_zone with refrigeration_walkin_zone * remove latent case credit method already included in refrigeration case data * add ref equip list method example method to get refrigeration equipment list from building properties * adjust Gro space type ratios remove Gro RefWalkInCool and RefWalkInFreeze space types and place walkins in RefFoodPrep instead. ensure space type ratios sum to 1.0. * add typical refrigeration equipment list add list of typical refrigeration equipment by building type and space type. Typical case lengths and walkin area is linked to a reference size of the space type, and then model cases and walkins are scaled accordingly. Walkins have a minimum size of 80 ft2 and maximum size of 480 ft2. * Deactivating or deleting lines or files that do not belong in master right now. * Include updated test results reflecting changings from using OS 3.9.0. * Include updated test results reflecting changings from using OS 3.9.0. * update cases data - copy some existing cases to fill out all case types for all templates - change names to avoid commas in name for E+ * Update typical_refrigerated_cases.csv * remove all refrigeration objects in create typical * data_update (crac_only) e89e6c4 * Modify lookups. * deprecate model_add_typical_refrigeration replace model_add_typical_refrigeration with create_typical_refrigeration * remove comstock and deer refrigeration data * Updating regression tests to reflect changes in OS 3.9.0. Updating autozone.rb to reflect changes to space_type_apply_internal_load_schedules arguments. * Updating regression tests to reflect changes in OS 3.9.0. Updating autozone.rb to reflect changes to space_type_apply_internal_load_schedules arguments. * update typical refrigeration logic - fix typo in typical walkin csv - don't add a refrigeration system if there are no cases or walkins - add more tests * revert changes revert some breaking changes and file additions * temp disable necb tests * Add reference curves and fix some lookups. * update doe regressions to OS v3.9 Disable large offices until the update to OS v3.10, which will include the E+ bug fix in E+ PR #10859 for cooling tower indexing * Update compare_models_helper.rb ERV table independent variable name lists are not deterministic * disable large offices tests revert once tests use OS v3.10, which will include the E+ bug fix in E+ PR #10859 for cooling tower indexing * Address test failures. * update typical refrigeration assumptions base on case and walkin amounts from an average of two case study buildings * rubocop fixes * add todo comment * Update space_type_ratios.rb * disable large office tests * Update necb_helper.rb Parse json files and compare directly rather than a text comparison. * make separate system size limit an option argument * use clamp instead of .min.max * Revert "Update space_type_ratios.rb" This reverts commit 69a7e77. * Reapply "Update space_type_ratios.rb" This reverts commit c0aa8c7. * require thermal zone for refrigeration equipment * replace string lookup with typical refrigeration .csvs * remove excess compares in necb expected results * set case zone in create refrigeration system test * 8.0.rc1 * refrigeration data fixes - fix missing case - fix case defrost curve name - fix typo in compressor curve data * add 'Gro' to infiltration lookup * add exterior lighting supermarket test * Merge branch 'master' into LandanT/Issue129_CA_WAREH_OFFICE_Change * add ext lighting properties method * Update space_type_ratios.rb * Update Prototype.CentralAirSourceHeatPump.rb * Update .yardopts - add exterior lighting and refrigeration modules to documentation * Update simulation.rb Don't run simulation for sizing periods during sizing run. It will still run zone, system, and plant sizing, but not simulate the design days. * Update version.rb * set sizing flow fraction during heating to 1 Due to changes in EnergyPlus (NREL/EnergyPlus#10763), some models fail during system sizing for reheat coils, particularly in cold climate zones (ASHRAE CZ 8). This sets the flow fraction to 1.0 instead of relying on the lower default in OpenStudio. * update regression models only minor change to set 'Heating Maximum Air Flow Fraction' in the 'SizingZone' object rather than using default. * 0.8.0.rc3 * fix log message variables * Update version.rb * change case schedule name * add more DEER bldg types to NIST infiltration * change exhaust fan log msg to debug * Update Lighting, Occupancy, and Equipment Schedules for 90.1 Models * Update lighting, occupancy, and equipment schedules for DEER Grocery Models * disable self-contained units Disable self-contained refrigeration units until we have efficiency data and cases and walkins can connect to those systems and simulate correctly. * Attempt to fix NECB test failures. * Add a failing test for#1946 This is the official E+ Kona file: https://energyplus.net/weather-location/north_and_central_america_wmo_region_4/USA/HI/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3 https://energyplus-weather.s3.amazonaws.com/north_and_central_america_wmo_region_4/USA/HI/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3/USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.zip * `iconv -f WINDOWS-1252 -t UTF-8 USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.stat -o new && mv new USA_HI_Keahole-Kona.Intl.AP.911975_TMY3.stat` * Fix #1946 - Don't throw when parsing a stat file that has no discernible dry period * Add a test for #1948 using https://climate.onebuilding.org/WMO_Region_4_North_and_Central_America/USA_United_States_of_America/CO_Colorado/USA_CO_Denver.Intl.AP.725650_TMYx.2009-2023.zip * Fix #1948 - allow parsing TMYx stat files * add default design conditions for ERV properties resolve multiple data return message in the erv properties lookup only impacts 90.1-2013 and 90.1-2016 * switch data from .csv to .json - .csv files don't get built in the embedded gem in ruby in OpenStudio. Convert the data to .jsons and use the .jsons instead. - adjust logging message location for infiltration * Add .gitignore for temp measure testing add a .gitignore for a directory to test measure for openstudio-standards integration testing * full case statement for design conditions * error message if no climate zone * Update version.rb * use File.dirname(__FILE__) instead of __dir__ * rubocop fixes * fix yard doc errors * Change StatFIle design size info to warning * use save navigation operator in json converter use safe navigation operator to get null instead of 0 for fields to avoid divide by zero or inappropriate zero values * revert changes to 90.1-2016 ervs * parking data safe navigation * use File.dirname(__FILE__) instead of __dir__ * update version * use helper function file? to check if file exists in the cli embeeded file system * formatting csv fiels as UTF-8 without the BOM marker * Add parallel option in the measure to parallelize the baseline sizing run based on orientation. disable parallel in CI testing * Attempt to fix NECB test failures, bis. * Address add HVAC systems and regression test failures. * Exclude PTHPs from specific search criteria and fix typo. * Missing objects. * Rubocop * Update Standards.CoilCoolingDXMultiSpeed.rb update data properties comment * add run design day sim option to model_run_sizing_run Add sizing_run_simulation argument to model_run_sizing_run defaulted to false. For NECB tests, set to true for the few NECB tests using CGSHP that require full design day runs for sizing. * Update create_case.rb * change default design day sim to true Setting to false causes some issues with SingleSpeed DX coils in the set COP and capacity lookups; possibly related to how the get capacity methods are implemented. * Updating NECB regression and unit test expected results. * Inculding references to space module * Reverting btap_cli test run_options.yml files. * make supermarket schedules constant Set constant values for heating and cooling schedules. The original values were from end use data, which was an average. It appears some stores had setbacks and most didn't, and the results is slight (1C) setbacks overnight. That causes issues in parametric schedules and sawtooth schedules. This commit changes the values to a constant average temperature. * simplify schedule * Resize any DX heating coils with a very small capacity to a capacity of 1 kW if sizing run foils and rerun sizing run. * Logging resizing of DX heating coil capacity * Update necb_2011.rb * Create separate sizing run method that handles DX coil failures. Use in NECB2011 and BTAPPRE1980 classes. * Adding try_sizing_run method to sizing run 2. Inculding sizing run subdirectory as try_sizing_run method argument. * Changing autozone.rb so methods use try_sizing_run method. Updating try_sizing_run method to include additional argument from master. * add defrost and dripdown schedule variation add defrost and dripdown schedule variation to refrigerated cases and walkins. Iterate the start hour over the cases and walkins added to the model. Add fields for defrosts per day and duration to the typical cases and walkins data. Assumptions for these values are placeholder values for now, based on prior values and a quick internet search. The purpose for adding variation is so that all the schedules aren't synced and cause a spiky profile in demand. * including space_multiplier_map in model_create_thermal_zones in apply_auto_zoning method. * Add modal validation back to try_sizing_run method. * Removing test line * Inculde HighriseApartment model that uses TZ multipliers instead of modelling each floor explicitly. * Update regression test files. * Update btap_datapoint.rb to enable missing require statements * Intentionally breaking GSHP costing to test AWS. * update defrost and dripdown schedules - for cases, default to one 45 minute defrost cycle per day followed by a 5 minute dripdown - for walkins, default to two 45 minute defrost cycles per day followed by a 5 minute dripdown - add logic to avoid adding defrost and dripdown schedules if offcycle - add logic to handle dripdowns exceeding the hour after a defrost - update cases and walkins defrost and dripdown values from the ORNL database * Removing intentional error * Updating regression test results even though all tests had passed * Update costing file paths * Making costing file path absolute * Update which applies the local costing .csv files, fixing the costing issue (#1981) * Removed costing_database.json, changed update_costing to validate_costing, changed how the database is loaded. * Changed all occurences of .exists? to .exist? --------- Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com> --------- Co-authored-by: Xu, Weili <weili.xu@pnnl.gov> Co-authored-by: Lerond <jeremy.lerond@pnnl.gov> Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com> Co-authored-by: Jeremy L. <5149279+lymereJ@users.noreply.github.com> Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov> Co-authored-by: Taylor <landan.taylor@nrel.gov> Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com> Co-authored-by: lymereJ <jeremy.lerond@gmail.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com> Co-authored-by: Eric Ringold <ericringold@gmail.com> Co-authored-by: tijcolem <tjc.coleman@gmail.com> Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com> * Refactor devcontainer setup: move post-create commands to setup.sh for better organization * Refactor timing data structure in ParallelTests - Changed the key for storing total test duration from 'total' to 'time' for clarity. - Sorted the timings JSON by test duration before saving. - Removed 'start' and 'end' keys from the saved timings data to streamline the output. --------- Co-authored-by: Xu, Weili <weili.xu@pnnl.gov> Co-authored-by: Lerond <jeremy.lerond@pnnl.gov> Co-authored-by: Matthew Dahlhausen <matthew.dahlhausen@gmail.com> Co-authored-by: Jeremy L. <5149279+lymereJ@users.noreply.github.com> Co-authored-by: Xuechen (Jerry) Lei <xuechen.lei@pnnl.gov> Co-authored-by: Taylor <landan.taylor@nrel.gov> Co-authored-by: Landan Taylor <128543626+LandanT@users.noreply.github.com> Co-authored-by: lymereJ <jeremy.lerond@gmail.com> Co-authored-by: Julien Marrec <julien.marrec@gmail.com> Co-authored-by: Eric Ringold <ericringold@gmail.com> Co-authored-by: tijcolem <tjc.coleman@gmail.com> Co-authored-by: Nicholas Pneumaticos <nicholaspneu@gmail.com> Co-authored-by: plopez <phylroy.lopez@nrcan-rncan.gc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.