Skip to content

Add 2014 to WIND Toolkit years per API documentation#963

Merged
cpaulgilman merged 1 commit into
patchfrom
wind-toolkit-years
Mar 2, 2022
Merged

Add 2014 to WIND Toolkit years per API documentation#963
cpaulgilman merged 1 commit into
patchfrom
wind-toolkit-years

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Mar 1, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Add 2014 to list of WIND Toolkit SRW files SAM can download from Wind Resource page. Acceptable values of "year" parameter are 2007 - 2014: https://developer.nrel.gov/docs/wind/wind-toolkit/wtk-srw-download/

Sample test URL for 2014:

https://developer.nrel.gov/api/wind-toolkit/v2/wind/mexico-wtk-download.csv?wkt=POINT(-103%2023)&names=2014&utc=false&leap_day=true&full_name=Data%20Lover&email=data.lover%40gmail.com&affiliation=NREL&api_key=DEMO_KEY

Fixes #961

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Mar 1, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou March 1, 2022 21:47
@cpaulgilman cpaulgilman self-assigned this Mar 1, 2022

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well!

@cpaulgilman cpaulgilman merged commit 081691a into patch Mar 2, 2022
@cpaulgilman cpaulgilman deleted the wind-toolkit-years branch March 2, 2022 17:33
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option for year 2014 in WIND Toolkit download

2 participants