Update pvsamv1 to apply DC degradation linearly#756
Merged
Conversation
added 3 commits
November 11, 2021 10:25
…n and put a warning in the upgrade script
brtietz
requested changes
Nov 12, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Something is wrong with test_script_ow.lk here - why are 146 lines now 46?
Collaborator
Author
|
Oh dear. I'll take a look and fix that when I re-run the script before merging. |
brtietz
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with NatLabRockies/ssc#654 . This updates the user interface, upgrade script, and defaults results. FYI @cpaulgilman this will require a documentation update.