Update pvsamv1 and pvwattsv8 to linear DC degradation rather than compounding#654
Conversation
… compounding DC degradation per NREL experts. fixes #503
…ation, so the answer should change
brtietz
left a comment
There was a problem hiding this comment.
Two questions on this prior to approving:
(1) Do we need any code protecting the output from values > 100 / analysis period? Previously the pow function would protect us from negative numbers, but we lose that with the linear formulation.
(2) Does this significantly (>0.1%) change the output in test_script_ow.lk? Based on the lack of change in the SSC tests we should be ok, but if one of us has time it might be worth running prior to merging.
|
Question (2) makes me look like I can't read. Nevermind on that one, I've reviewed SAM 756 as well now. |
|
|
@brtietz Updated the logic to address question 1, please review additions to lib_pv_io_manager when you get a chance. Thanks! |
brtietz
left a comment
There was a problem hiding this comment.
The new code and warning flag work great, thanks!
Per NREL experts, updating the detailed pv model and the newest pvwatts version to apply DC degradation linearly instead of compounding. All SSC tests are passing locally. Pairs with NatLabRockies/SAM#756 PR to update defaults results and the upgrade script. Fixes #503 .