Refactor battery enums#681
Merged
Merged
Conversation
…oice variable. Should maintain existing behavior at this point
… needs to be updated. speeds up file loading and toggling between dispatch and other tabs
… doesn't run when weather file is an empty string
sjanzou
requested changes
Aug 16, 2021
sjanzou
approved these changes
Aug 18, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Yay! Defaults working now!
dguittet
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the GUI given the changes in SSC PR NatLabRockies/ssc#602, and expands the scope of the custom weather file forecast to AC batteries and PV smoothing. Fixes #676 BTM forecasting will be another PR.
Forecast will run in a callback when the weather file is specified and option 2 is selected. SSC will throw an error if the forecast is not specified. Note that for large weather files, the slowdown on the "Location and Resource" page exists on the released version as well.