Skip to content

New Operating Costs input page#653

Merged
cpaulgilman merged 9 commits into
developfrom
operating_costs
Jul 14, 2021
Merged

New Operating Costs input page#653
cpaulgilman merged 9 commits into
developfrom
operating_costs

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

This PR is a prerequisite for fixing #355 (see also related NatLabRockies/ssc#530) and adding new inputs for Community Solar financial model. Changes include:

  • Separate Installation Costs and Operating Costs input pages

  • UI forms for operating costs, operating costs with fuel, battery, and fuel cell.

  • Update defaults for operating cost inputs.

  • Remove unused battery-related operating cost inputs from PVWatts Battery configurations.

  • New structure for Help topics on costs.

Rename UI forms to start with "Operating Costs" so one for for regular, battery, fuel cell, and CSP (with fossil fuel cost).

Update defaults to remove unused O&M variables.
Separate forms for PV battery and generic battery operating costs to avoid conditional display of fuel cost variables.

Update defaults to match new UI forms
…st defaults

Generic system defaults for om_fuel_cost set to $10/MMBtu for all configs (was $5/MMBtu for residential, and $10.37 for commercial, and a mix of 0 and $10 for others).
@mjprilliman

Copy link
Copy Markdown
Collaborator

image

image

I think you need some text for these new section header pages in the Help Paul.

@mjprilliman

mjprilliman commented Jul 13, 2021

Copy link
Copy Markdown
Collaborator

image

I would like to propose something like this for the marine models to be consistent. Those changes may be in a separate PR down the road. Commit pushed to this branch

@mjprilliman

Copy link
Copy Markdown
Collaborator

image

Do you want wave, tidal, and concentrating PV costs to be in this menu or leave them in the existing technology menus?

@mjprilliman

mjprilliman commented Jul 13, 2021

Copy link
Copy Markdown
Collaborator

image

Typo. Commit pushed to this branch

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@sjanzou

sjanzou commented Jul 14, 2021

Copy link
Copy Markdown
Collaborator

Running all defaults on Windows fails with MEwave / LCOE calculator:
image

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the $/kWh battery replacement costs discussed at the 7/13/21 SAM meeting and if the failing UI with MEwave / LCOE calculator is fixed (see comments) and all tests passing, that this should be ready to go and getting merged into develop before community solar is great! Thanks for tackling this!

@mjprilliman

Copy link
Copy Markdown
Collaborator

I think with the $/kWh battery replacement costs discussed at the 7/13/21 SAM meeting and if the failing UI with MEwave / LCOE calculator is fixed (see comments) and all tests passing, that this should be ready to go and getting merged into develop before community solar is great! Thanks for tackling this!

I'm pretty sure the MEwave defaults issue is a quirk with the library building. On load the case config is looking at the existing local app data for the WaveResourceData.csv file, which has different variable names that have since been changed in the IDE library object and library setup scripts. Clicking 'Refresh library' should rewrite the library and fix the issue. I didn't find a way to update this automatically as the check happens before the pages load so it would be a more complicated fix. The hope is that this is going into a new release version so the local app data would be brand new and not looking at any existing WaveResourceData.csv files on first load.

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

I'm not seeing the message about 'file_name', and given Matt's comments will go ahead with the merge.

@cpaulgilman cpaulgilman merged commit f9ac517 into develop Jul 14, 2021
@cpaulgilman cpaulgilman mentioned this pull request Jul 14, 2021
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
@cpaulgilman cpaulgilman deleted the operating_costs branch December 7, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants